Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User a less confusing display string for the scope tokens for triggers #1705

Merged
merged 3 commits into from Dec 9, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 5, 2013

Read my comment at #1531 - says everything you need to know

  • Use the bundle's CFBundleDisplayName (if it exists - or fall back to CFBundleName)
  • Add a menu to the token allowing you to see the original bundle ID

pjrobertson added 3 commits Dec 5, 2013
…scope view

Fixes #1531
Plus: Add a menu to the token to show the represented object
Fall back to the bundle name if none exists
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Dec 5, 2013

Here's a nice pic to show what I mean
screen shot 2013-12-05 at 18 04 51

@skurfer
Copy link
Member

@skurfer skurfer commented Dec 5, 2013

Seems like a good improvement. I assume you used a menu because tooltips aren’t an option in that context?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Dec 6, 2013

Meh, tooltips work on any NSView, so they would work here, but using a menu was just easier. I think it’s actually more obvious as well.

Aside: if fact, I’ve never actually managed to get addToolTipRect:owner:userData: working, it seems fiddly. This way is much easier :)

On 5 Rhag 2013, at 23:06, Rob McBroom notifications@github.com wrote:

Seems like a good improvement. I assume you used a menu because tooltips aren’t an option in that context?


Reply to this email directly or view it on GitHub.

skurfer added a commit that referenced this issue Dec 9, 2013
User a less confusing display string for the scope tokens for triggers
@skurfer skurfer merged commit 9165dfa into master Dec 9, 2013
1 check passed
@skurfer skurfer deleted the i1531 branch Dec 9, 2013
skurfer added a commit that referenced this issue Dec 9, 2013
skurfer added a commit that referenced this issue Dec 9, 2013
skurfer added a commit that referenced this issue Dec 10, 2013
skurfer added a commit that referenced this issue Dec 10, 2013
skurfer added a commit that referenced this issue Dec 11, 2013
skurfer added a commit that referenced this issue Dec 11, 2013
skurfer added a commit that referenced this issue Dec 18, 2013
skurfer added a commit that referenced this issue Dec 19, 2013
skurfer added a commit that referenced this issue Jan 2, 2014
skurfer added a commit that referenced this issue Jan 14, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 21, 2014
skurfer added a commit that referenced this issue Jan 25, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 5, 2014
skurfer added a commit that referenced this issue Feb 11, 2014
skurfer added a commit that referenced this issue Mar 19, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants