Tack on a (nil) argument if the selector is asking for one

[pjrobertson]

Seems like pre-ARC would tack on a nil argument when calling performSelector: on a selector that required an argument, but for which none was provided.
Now, we have to explicitly check if the selector requires an argument, and tack one on (nil in this case) if none is provided.

Fixes @philostein's bug found Rob mentioned

[skurfer]

With this change, I just get a crash in sendMessage: now instead of on toggle:. (Although the panel is made visible first.)

In any case, if the problem is that not enough arguments are being passed to the selector, why does it get through showClipboard: OK, but then crash on toggle:.

[pjrobertson]

Hmm... I see your point Rob. I think this gives the answer. When argument is nil, ARC is trying to retain junk, and causing a crash. @craigotis - have you come across this in your ARC days?

[pjrobertson]

From what I gather we have two ways we can go:

• In QSObjCMessageSource, if argument is nil then we can instead send self (or maybe NSNull):
  result = [target performSelector:selector withObject:argument ? argument : self];
• Add a new - (void)toggle; action to QSDockingWindow that accepts no argument, and revert my last commit. This would only fix that one particular method though (toggle:). My guess is that there are may more that were silently accepting nil arguments before, but now crash under ARC

Personally I think we should go with option 1, but am open to discussion

[craigotis]

You can use, in ARC, without error:

- (void)applicationDidFinishLaunching:(NSNotification *)aNotification
{
    // Insert code here to initialize your application
    [self performSelector:@selector(test:) withObject:nil];
}

- (void)test:(id)something {
    NSLog(@"Testing");
}

[pjrobertson]

True, that doesn't crash, but this does:

@interface ISAppDelegate (extras)
@property id thing;
@end

@implementation ISAppDelegate

- (void)applicationDidFinishLaunching:(NSNotification *)aNotification
{
    // this crashes
    [self performSelector:@selector(test:)];
}

- (void)test:(id)sender {
    // retain 'thing'
    self.thing = sender;
    // release 'thing' (and 'sender' - which is GARBAGE!)
    self.thing = nil;

}

@end

Basically, trying to do something with the object (i.e. retain/release it) causes a crash. As for the 2nd crash - it is because in our current code we're trying to get a 'return value' from performSelector, whereas toggle: is an action of type void. This crashes in ARC as well:

@implementation ISAppDelegate

- (void)applicationDidFinishLaunching:(NSNotification *)aNotification
{
    // this crashes
    id result = [self performSelector:@selector(test:) withObject:nil];
}

- (IBAction)test:(id)sender {
    // retain 'thing'
    self.thing = sender;
    // release 'thing' (and sender. In this case it's fine, because we've explicitly sent `nil` above)
    self.thing = nil;
    // nothing is returned... we're void
}