Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-configure Product Name #1738

Merged
merged 3 commits into from Feb 5, 2014
Merged

auto-configure Product Name #1738

merged 3 commits into from Feb 5, 2014

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Dec 31, 2013

You know how we tell plug-in devs to remove all the bold build settings except “Product Name”? I don’t think that’s necessary. If we set PRODUCT_NAME to TARGET_NAME, all the plug-ins can get a reasonable value automatically (and we can just tell people to delete all the bold settings).

I’ve also:

  • Removed the hard-coded product name from all the built-in plug-ins
  • For the targets that aren’t plug-ins, but the product name is the same as the target name, I’ve removed the hard-coded product name and replaced it with $(TARGET_NAME)
  • Changed the Finder plug-in’s target from “Finder Module” to “Finder Plugin”

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Dec 31, 2013

ok to test

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 5, 2014

Just to make sure: what if a plugin has a TARGET_NAME of say "Clipboard Module", and we go down this route - we'd have to make sure we rename the target to "Clipboard Plugin", otherwise the name of the plugin would change the next time we build right?

@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 5, 2014

Short version: This won’t affect existing plug-ins in any way.

  1. All of the plug-ins currently have “Product Name” hard-coded, so this change to the .xcconfig will have no effect on any plug-in unless you go in and “delete” the bold Product Name setting. At that point, the target name will need to be corrected if wrong, but if you’re updating one, you can update the other. And you’ll probably notice if the Product Name suddenly looks wrong.
  2. Even after you switch to using $TARGET_NAME for Product Name, it would only change the name of the executable, not the visible name of the plug-in. (Although, maybe we should eventually tie those together, too.) The executable name could change with every version and, as far as I know, it would make no difference (as long as the plist has the correct name too).

pjrobertson added a commit that referenced this issue Feb 5, 2014
@pjrobertson pjrobertson merged commit 44e2b20 into master Feb 5, 2014
1 check passed
@pjrobertson pjrobertson deleted the targets branch Feb 5, 2014
skurfer added a commit that referenced this issue Feb 5, 2014
skurfer added a commit that referenced this issue Feb 11, 2014
skurfer added a commit that referenced this issue Mar 19, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants