auto-configure Product Name

[skurfer]

You know how we tell plug-in devs to remove all the bold build settings except “Product Name”? I don’t think that’s necessary. If we set PRODUCT_NAME to TARGET_NAME, all the plug-ins can get a reasonable value automatically (and we can just tell people to delete all the bold settings).

I’ve also:

• Removed the hard-coded product name from all the built-in plug-ins
• For the targets that aren’t plug-ins, but the product name is the same as the target name, I’ve removed the hard-coded product name and replaced it with $(TARGET_NAME)
• Changed the Finder plug-in’s target from “Finder Module” to “Finder Plugin”

[HenningJ]

ok to test

[pjrobertson]

Just to make sure: what if a plugin has a TARGET_NAME of say "Clipboard Module", and we go down this route - we'd have to make sure we rename the target to "Clipboard Plugin", otherwise the name of the plugin would change the next time we build right?

[skurfer]

Short version: This won’t affect existing plug-ins in any way.

1. All of the plug-ins currently have “Product Name” hard-coded, so this change to the .xcconfig will have no effect on any plug-in unless you go in and “delete” the bold Product Name setting. At that point, the target name will need to be corrected if wrong, but if you’re updating one, you can update the other. And you’ll probably notice if the Product Name suddenly looks wrong.
2. Even after you switch to using $TARGET_NAME for Product Name, it would only change the name of the executable, not the visible name of the plug-in. (Although, maybe we should eventually tie those together, too.) The executable name could change with every version and, as far as I know, it would make no difference (as long as the plist has the correct name too).