Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a QSWindow retain issue #1739

Merged
merged 1 commit into from Jan 2, 2014
Merged

Conversation

craigotis
Copy link
Contributor

@craigotis craigotis commented Dec 31, 2013

Updates the QSWindow to no longer maintain a list of retained windows, and also updates the QSLargeTypeDisplay's window to release itself when closed.

…, and also updates the QSLargeTypeDisplay's window to release itself when closed.
craigotis referenced this issue Dec 31, 2013
…n the QSTriggerManager/QSWindow that would cause a crash in ARC.
@skurfer
Copy link
Member

@skurfer skurfer commented Jan 2, 2014

Yep. Seems to work fine (and makes more sense).

skurfer added a commit that referenced this issue Jan 2, 2014
@skurfer skurfer merged commit 83d64c5 into quicksilver:master Jan 2, 2014
1 check passed
skurfer added a commit that referenced this issue Jan 2, 2014
@craigotis craigotis deleted the qswindow-leak-fix branch Jan 2, 2014
skurfer added a commit that referenced this issue Jan 14, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 21, 2014
skurfer added a commit that referenced this issue Jan 25, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 5, 2014
skurfer added a commit that referenced this issue Feb 11, 2014
skurfer added a commit that referenced this issue Mar 19, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants