Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check file URLs if they are ubiquitous (iCloud docs) #1745

Merged
merged 2 commits into from Jan 17, 2014
Merged

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 8, 2014

Fixes a small comment Rob made on the 10.9 bug page.

I've looked into the revealing of iCloud items in Finder and it doesn't seem possible... now I have a bigger can of worms to work with

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 8, 2014

If this is the best we can do, I’ll take it, but any ideas why the NSFileManager method quit working? It seems tailor-made for a situation like this.

Also, from reading the docs on isUbiquitousItemAtURL:, with your changes, it’s now checking that the file has been uploaded to iCloud, which isn’t really what we want. We just want to know if it’s supposed to be uploaded at some point.

I’d almost rather just check the parent folder like I did on the very first try.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 8, 2014

OK, then how about NSURLIsUbiquitousItemKey

See NSURL.h
The other options would be to check: NSURLUbiquitousItemDownloadingStatusKey and see what is returned. It’d probably be nil for non-ubiquitous items (but this is 10.9+ only)

On 8 Ion 2014, at 11:36, Rob McBroom notifications@github.com wrote:

If this is the best we can do, I’ll take it, but any ideas why the NSFileManager method quit working? It seems tailor-made for a situation like this.

Also, from reading the docs on isUbiquitousItemAtURL:, with your changes, it’s now checking that the file has been uploaded to iCloud, which isn’t really what we want. We just want to know if it’s supposed to be uploaded at some point.

I’d almost rather just check the parent folder like I did on the very first try.


Reply to this email directly or view it on GitHub.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 8, 2014

See my force-pushed updates. The 2nd commit is a hangover from me trying to fix the 2nd thing you mentioned (reveal in Finder).
Even though it doesn't fix it, it'll be useful for revealing files when using the comma trick (which currently doesn't work... hence my can of worms)

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 8, 2014

OK, then how about NSURLIsUbiquitousItemKey

Seems more in line with what we were doing before. As long as you’re force-pushing… Can you indent line 144 with spaces like the rest. It’s not lining up right now.

I’ll test the other changes with the Path Finder plug-in and update it if necessary.

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 8, 2014

Oh, I guess I can’t test Reveal with the comma trick until we sort out the problem with actions. :-)

It’s not present in 4008, so it must have been introduced recently.

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 17, 2014

Made a branch that combines ubiquitous with nsstringuti to test the Reveal changes. Works great. The Path Finder behavior could be improved, but it’s passable as is.

skurfer added a commit that referenced this issue Jan 17, 2014
Properly check file URLs if they are ubiquitous (iCloud docs)
@skurfer skurfer merged commit 0465c78 into master Jan 17, 2014
1 check passed
@skurfer skurfer deleted the ubiquitous branch Jan 17, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 21, 2014
skurfer added a commit that referenced this issue Jan 25, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 5, 2014
skurfer added a commit that referenced this issue Feb 11, 2014
skurfer added a commit that referenced this issue Mar 19, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants