Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send app launch notifications when reloading #1758

Merged
merged 1 commit into from Jan 25, 2014
Merged

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jan 23, 2014

The fix for #1756 turned out to be pretty simple. There was already an isReloading boolean to prevent certain behaviors when adding existing processes. I just put the app launch notification under that.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 25, 2014

I was going to say “this is all and well, but what does it break?”
Now looking at it, it seems the only place actually using that notif is the Event Triggers plugin (including all the plugins I currently have on my system, which isn’t all of them)

So I guess this is fine :)

On 24 Ion 2014, at 06:44, Rob McBroom notifications@github.com wrote:

The fix for #1756 turned out to be pretty simple. There was already an isReloading boolean to prevent certain behaviors when adding existing processes. I just put the app launch notification under that.

You can merge this Pull Request by running

git pull https://github.com/quicksilver/Quicksilver applaunch
Or view, comment on, or merge it at:

#1758

Commit Summary

don't send app launch notifications when reloading
File Changes

M Quicksilver/Code-QuickStepCore/QSProcessMonitor.m (2)
Patch Links:

https://github.com/quicksilver/Quicksilver/pull/1758.patch
https://github.com/quicksilver/Quicksilver/pull/1758.diff

Reply to this email directly or view it on GitHub.

pjrobertson added a commit that referenced this issue Jan 25, 2014
don't send app launch notifications when reloading
@pjrobertson pjrobertson merged commit e55dd9c into master Jan 25, 2014
1 check passed
@pjrobertson pjrobertson deleted the applaunch branch Jan 25, 2014
skurfer added a commit that referenced this issue Jan 25, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 5, 2014
skurfer added a commit that referenced this issue Feb 11, 2014
skurfer added a commit that referenced this issue Mar 19, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants