Clear caches when downgrading as well as upgrading QS #1762
Conversation
| @@ -1004,11 +1005,11 @@ - (void)startQuicksilver:(id)sender { | |||
| if ([defaults boolForKey:kAutomaticTaskViewer]) | |||
| [QSTaskViewer sharedInstance]; | |||
|
|
|||
| if ( ! (runningSetupAssistant || newVersion) ) | |||
| if ( ! (runningSetupAssistant || versionChanged) ) | |||
There was a problem hiding this comment.
Should this be if (!runningSetupAssistant && versionChanged). The meaning of the BOOL has changed, so I think the test needs to be altered slightly. But maybe I’m missing something, because the old line looks wrong, too.
There was a problem hiding this comment.
Well... the meaning of the BOOL is the same really. If it's a new version (newVersion == YES) of Quicksilver, then the version has changed (versionChanged == YES)
I'm not quite sure what you're getting at. Nothing's changed... anyway, that line is right:
If we're not running the setup assistant or the version number hasn't changed (i.e. this is a normal launch) then just rescan all catalog indexes as usual. Rescanning isn't the same as wiping and scanning (because the scan isn't forced).
If you follow the code that line calls -[QSLibrarian scanCatalogIgnoringIndexes:NO] i.e. - not a forced scan.
There was a problem hiding this comment.
aaaah dammitt, stupid internet meant I lost my post. Here's the jist of it:
The meaning hasn't changed, just expanded. versionChanged == (newVersion || oldVersion)
That line is right: if this is a normal QS launch (not an upgrade/downgrade and the setup assistant isn't running) then just scan the catalog as normal. The next line doesn't force a rescan (follow it down through the code, you'll see a rescan is done with force == NO)
Trying to pick holes in this tiny commit eh? ;-)
There was a problem hiding this comment.
OK, I think you’re right. I hadn’t followed rescanItems: down far enough.
Clear caches when downgrading as well as upgrading QS
Forgot to say… Yeah, that’s the right way to go. Until the release goes out, I’m just rebasing the |
As Rob and I discussed on quicksilver/elements.trigger.event-qsplugin#2, it's also often worth clearing caches when downgrading QS.
Anyhow, rescanning the catalog is hardly a big deal. I think this should go in v1.2 (but I'm pulling against master, I hope that's OK :/)