Nsdateformatter - again #1765
Merged
Nsdateformatter - again #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To find the last scan date, use the latest scan date from its children
| // It's a group entry. Loop through the child catalog entries to find the one with the latest scan date | ||
| NSDate *latestScan = nil; | ||
| for (QSCatalogEntry *child in [self children]) { | ||
| NSDate *childScanDate = [[[NSFileManager defaultManager] attributesOfItemAtPath:[child indexLocation] error:nil] objectForKey:NSFileModificationDate]; |
There was a problem hiding this comment.
Couldn’t this just be [child lastScanDate]?
|
Right you were @skurfer on both those occasions. Fixed :) |
It seemed right, but doesn’t appear work. Groups seem to always claim they can be indexed. This test appears to work: |
|
Silly to make you deal with such a small change, especially when it was already sitting here in my local copy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Dammit, so you merged the last pull in too quick @skurfer ;-)
I found another place where the
NSDateFormatterwas wrong - in the Scanned field of the 'attributes' tab of a catalog entry (the Prefs).This is just a pull that changes that and adds one small change:
For Catalog Groups, if they don't have an actual
.qsindexfile (i.e. they're just a group and not a catalog entry) the Scanned date would show up empty. What I've done here is just use the most recent scanned date from any of the group's children.