Aliases #1770

pjrobertson · 2014-02-08T04:26:38Z

3 small things:

Add the alias arrow icon to alias objects
Tacks a (alias) onto the details of alias objects
Use an object's UTI for getting the quick icon from NSWorkspace (implications unknown, but my guess is it's an improvement)

skurfer · 2014-02-10T15:18:29Z

I thought this would be an easy merge, but now I think I have something to say about all three commits. Sorry. 😬

pjrobertson · 2014-02-12T03:21:40Z

OK, take a look at the latest commits. They blow away LSInfoRec and use the NSURL method. I've also gone ahead and added a few more fancy things, as you know I can never help myself from making simple pulls complicated :)

The last commit should stop the silly CA Uncommitted Transaction warnings in the console.

…SInfoRec

…28

pjrobertson · 2014-02-12T04:11:02Z

OK this needs work:

The NSURL resource methods don't work all the time (namely for /.dbfseventsd
The alias resolving doesn't work all the time (namely for /tmp)

Should we scrap this and go back to how it was, or keep this and keep the old method as a fallback?

skurfer · 2014-02-12T19:01:02Z

The alias resolving doesn't work all the time (namely for /tmp)

I did some testing in a stand-alone project, and /tmp was fine as long as you don’t call stringByStandardizingPath on it. If you do, you just end up looking at /private/tmp instead.

…rking We have to revert back to the 'old' way for socket type files because the NSURL method doens't work

pjrobertson · 2014-03-12T11:14:39Z

OK, I've made some changes to how this works now. I don't like it 100%, since we fall back to using the 'old' method in the rare cases that we can't get any information form NSURL (this only happens for unix:// sockets, and I'm not actually sure if the LSInfoRecord method gives us anything useful either.

skurfer · 2014-03-12T14:47:46Z

Looks good other than the one comment. I’ll remove that code from my local copy and test the rest for a while.

…e bytes

- instead of hitting the disk Also, do the same when retrieving NSURL keys (cache all key/values in one call)

It only occurs for fifos and sockets, but the files can still be added to QS

Caused a slight bug where mutableDict ended up being nil

Determines if a given file object can be run (e.g. in a shell) Whilst determining this, also check to make sure the file isn't a pipe/socket

pjrobertson · 2014-03-19T10:39:24Z

OK, finally figured it out :P Take a look and see what you think

skurfer · 2014-03-24T13:21:12Z

Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m

-                newLabel = (NSString *)CFBridgingRelease(MDItemCopyAttribute(mdItem, kMDItemDisplayName));
-                CFRelease(mdItem);
-            }
-        }


Why was all this logic removed? Quicksilver plug-ins and Preference Panes have ugly names now. (I’m not too worried about plug-ins.)

skurfer · 2014-05-16T12:40:26Z

I think this is fine, other than the naming of Preference Panes.

pjrobertson · 2014-05-29T18:10:56Z

OK, so the changes in this file (the changes to how we retrieve file object info - like the UTI) is related to #1841, and should fix it. Shall we try and get this merged into v.1.2.0 then we'll hopefully be able to do away with any more annoying UTI problems

Conflicts: Quicksilver/Code-QuickStepInterface/QSSearchObjectView.m

skurfer · 2014-05-29T18:18:29Z

Shall we try and get this merged into v.1.2.0 then we'll hopefully be able to do away with any more annoying UTI problems

Sure. Just fix my precious preference panes. 😃

But remove code for giving QSPlugins fancy names

NSURLLocalizedNameKey gives exactly the same as `[[NSFileManager defaultManager] displayNameAtPath:path]`. There's no point hitting the disk again for a pointless reason

skurfer · 2014-05-29T19:17:58Z

Hmmm. Have you tried clearing caches and running this? Preference Panes look good, but I was going to test Fast Logout.sh and the Extra Scripts aren’t getting indexed at all. I’ll try to figure out why if I have time later.

pjrobertson · 2014-05-30T03:10:57Z

Well spotted, a silly mistake really.

See the latest commit for why… oops!

On 30 Mai 2014, at 02:17, Rob McBroom notifications@github.com wrote:

Hmmm. Have you tried clearing caches and running this? Preference Panes look good, but I was going to test Fast Logout.sh and the Extra Scripts aren’t getting indexed at all. I’ll try to figure out why if I have time later.

—
Reply to this email directly or view it on GitHub.

There was confusion over using the keys and the similarly named (but now-unused) variables E.g. URLIsDirectory vs. NSURLIsDirectoryKey

pjrobertson · 2014-05-30T03:15:01Z

P.S. is it just me, or is file browser now blazingly faster? That needs to go in the changelog ;-)

skurfer · 2014-05-30T03:43:39Z

Cool. I’ve merged this into my day-to-day build. I’ll try it for a while, but don’t see any issues now.

As for speed, I can’t tell much of a difference, but it certainly isn’t slow. (I usually check by arrowing into /usr/bin/.)

pjrobertson · 2014-05-30T03:50:14Z

Yep, it’ll need some testing. Since QSUTIWithLSInfoRec and NSURL’s NSURLTypeIdentifierKey give different values for the “Fast Logout.sh” script, I have no doubt that there will be discrepancies in other places.

But hopefully, any discrepancies will be for the better

On 30 Mai 2014, at 10:43, Rob McBroom notifications@github.com wrote:

Cool. I’ve merged this into my day-to-day build. I’ll try it for a while, but don’t see any issues now.

As for speed, I can’t tell much of a difference, but it certainly isn’t slow. (I usually check by arrowing into /usr/bin/.)

—
Reply to this email directly or view it on GitHub.

Aliases

pjrobertson added 6 commits Feb 12, 2014

add '(alias)' to the details of file alias objects

a17851c

Use the file UTI for getting a file obj icon from NSWorkspace

d1c155e

Add the alias (arrow) image overlay to alias object icons

17e3a9c

Bring aliases branch in line with master

ca0c032

Switch to using NSURL for finding file attributes

f485061

Add an isExecutable method for file QSObjects

a9d0ffc

pjrobertson added 3 commits Feb 12, 2014

Tidy up NSFileManager methods to use NSURL resource keys instead of L…

f54b701

…SInfoRec

Use Sparkle's auth method for moving restricted files to trash. Fixes #…

71caaed

…28

Update the results display on the main thread. (Similar to #1655)

5703587

Minor adjustments to get the new NSURL method of reading file info wo…

80a7c21

…rking We have to revert back to the 'old' way for socket type files because the NSURL method doens't work

pjrobertson added 7 commits Mar 15, 2014

Check a file UTI to see if it's executable before checking actual fil…

f4c0196

…e bytes

Make use the cached QSObject UTI

f44b231

- instead of hitting the disk Also, do the same when retrieving NSURL keys (cache all key/values in one call)

Don't log when NSURL info can't be found

5fc1c78

It only occurs for fifos and sockets, but the files can still be added to QS

Improve comments on file resolving methods

731fa3c

Merge branch 'master' into aliases

151bb7d

Don't overwrite the higher-scoped mutableDict

3435af3

Caused a slight bug where mutableDict ended up being nil

Add a new canBeExecutedByScript method

d781bac

Determines if a given file object can be run (e.g. in a shell) Whilst determining this, also check to make sure the file isn't a pipe/socket

skurfer reviewed Mar 24, 2014
View changes

Merge branch 'master' into aliases

32f7692

Conflicts: Quicksilver/Code-QuickStepInterface/QSSearchObjectView.m

skurfer added this to the 1.2.0 milestone May 29, 2014

pjrobertson added 3 commits May 29, 2014

Add unit tests for preference pane names

8c55596

Re-instate code for giving pref panes nice names

ecf1153

But remove code for giving QSPlugins fancy names

NSURLLocalizedNameKey is reliable all round

49d409e

NSURLLocalizedNameKey gives exactly the same as `[[NSFileManager defaultManager] displayNameAtPath:path]`. There's no point hitting the disk again for a pointless reason

Fix directory scanning using the new NSURLKeys

6eaede0

There was confusion over using the keys and the similarly named (but now-unused) variables E.g. URLIsDirectory vs. NSURLIsDirectoryKey

skurfer added a commit that referenced this issue May 30, 2014

Merge pull request #1770 from quicksilver/aliases

6aed887

Aliases

skurfer merged commit 6aed887 into master May 30, 2014
1 check was pending

skurfer deleted the aliases branch May 30, 2014

skurfer mentioned this pull request May 30, 2014

fast logout no longer working in 1.2.0 #1841

Closed

Aliases #1770

Aliases #1770

pjrobertson commented Feb 8, 2014

skurfer commented Feb 10, 2014

pjrobertson commented Feb 12, 2014

pjrobertson commented Feb 12, 2014

skurfer commented Feb 12, 2014

pjrobertson commented Mar 12, 2014

skurfer commented Mar 12, 2014

pjrobertson commented Mar 19, 2014

skurfer Mar 24, 2014

skurfer commented May 16, 2014

pjrobertson commented May 29, 2014

skurfer commented May 29, 2014

skurfer commented May 29, 2014

pjrobertson commented May 30, 2014

pjrobertson commented May 30, 2014

skurfer commented May 30, 2014

pjrobertson commented May 30, 2014

Aliases #1770

Aliases #1770

Conversation

pjrobertson commented Feb 8, 2014

skurfer commented Feb 10, 2014

pjrobertson commented Feb 12, 2014

pjrobertson commented Feb 12, 2014

skurfer commented Feb 12, 2014

pjrobertson commented Mar 12, 2014

skurfer commented Mar 12, 2014

pjrobertson commented Mar 19, 2014

skurfer Mar 24, 2014

Choose a reason for hiding this comment

skurfer commented May 16, 2014

pjrobertson commented May 29, 2014

skurfer commented May 29, 2014

skurfer commented May 29, 2014

pjrobertson commented May 30, 2014

pjrobertson commented May 30, 2014

skurfer commented May 30, 2014

pjrobertson commented May 30, 2014