Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases #1770

Merged
merged 22 commits into from May 30, 2014
Merged

Aliases #1770

merged 22 commits into from May 30, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 8, 2014

3 small things:

  • Add the alias arrow icon to alias objects
  • Tacks a (alias) onto the details of alias objects
  • Use an object's UTI for getting the quick icon from NSWorkspace (implications unknown, but my guess is it's an improvement)

@skurfer
Copy link
Member

skurfer commented Feb 10, 2014

I thought this would be an easy merge, but now I think I have something to say about all three commits. Sorry. 😬

@pjrobertson
Copy link
Member Author

pjrobertson commented Feb 12, 2014

OK, take a look at the latest commits. They blow away LSInfoRec and use the NSURL method. I've also gone ahead and added a few more fancy things, as you know I can never help myself from making simple pulls complicated :)

The last commit should stop the silly CA Uncommitted Transaction warnings in the console.

@pjrobertson
Copy link
Member Author

pjrobertson commented Feb 12, 2014

OK this needs work:

  • The NSURL resource methods don't work all the time (namely for /.dbfseventsd
  • The alias resolving doesn't work all the time (namely for /tmp)

Should we scrap this and go back to how it was, or keep this and keep the old method as a fallback?

@skurfer
Copy link
Member

skurfer commented Feb 12, 2014

The alias resolving doesn't work all the time (namely for /tmp)

I did some testing in a stand-alone project, and /tmp was fine as long as you don’t call stringByStandardizingPath on it. If you do, you just end up looking at /private/tmp instead.

…rking

We have to revert back to the 'old' way for socket type files because the NSURL method doens't work
@pjrobertson
Copy link
Member Author

pjrobertson commented Mar 12, 2014

OK, I've made some changes to how this works now. I don't like it 100%, since we fall back to using the 'old' method in the rare cases that we can't get any information form NSURL (this only happens for unix:// sockets, and I'm not actually sure if the LSInfoRecord method gives us anything useful either.

@skurfer
Copy link
Member

skurfer commented Mar 12, 2014

Looks good other than the one comment. I’ll remove that code from my local copy and test the rest for a while.

pjrobertson added 7 commits Mar 15, 2014
- instead of hitting the disk
Also, do the same when retrieving NSURL keys (cache all key/values in one call)
It only occurs for fifos and sockets, but the files can still be added to QS
Caused a slight bug where mutableDict ended up being nil
Determines if a given file object can be run (e.g. in a shell)
Whilst determining this, also check to make sure the file isn't a pipe/socket
@pjrobertson
Copy link
Member Author

pjrobertson commented Mar 19, 2014

OK, finally figured it out :P Take a look and see what you think

newLabel = (NSString *)CFBridgingRelease(MDItemCopyAttribute(mdItem, kMDItemDisplayName));
CFRelease(mdItem);
}
}
Copy link
Member

@skurfer skurfer Mar 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was all this logic removed? Quicksilver plug-ins and Preference Panes have ugly names now. (I’m not too worried about plug-ins.)

@skurfer
Copy link
Member

skurfer commented May 16, 2014

I think this is fine, other than the naming of Preference Panes.

@pjrobertson
Copy link
Member Author

pjrobertson commented May 29, 2014

OK, so the changes in this file (the changes to how we retrieve file object info - like the UTI) is related to #1841, and should fix it. Shall we try and get this merged into v.1.2.0 then we'll hopefully be able to do away with any more annoying UTI problems

Conflicts:
	Quicksilver/Code-QuickStepInterface/QSSearchObjectView.m
@skurfer skurfer added this to the 1.2.0 milestone May 29, 2014
@skurfer
Copy link
Member

skurfer commented May 29, 2014

Shall we try and get this merged into v.1.2.0 then we'll hopefully be able to do away with any more annoying UTI problems

Sure. Just fix my precious preference panes. 😃

pjrobertson added 3 commits May 29, 2014
But remove code for giving QSPlugins fancy names
NSURLLocalizedNameKey gives exactly the same as `[[NSFileManager defaultManager] displayNameAtPath:path]`. There's no point hitting the disk again for a pointless reason
@skurfer
Copy link
Member

skurfer commented May 29, 2014

Hmmm. Have you tried clearing caches and running this? Preference Panes look good, but I was going to test Fast Logout.sh and the Extra Scripts aren’t getting indexed at all. I’ll try to figure out why if I have time later.

@pjrobertson
Copy link
Member Author

pjrobertson commented May 30, 2014

Well spotted, a silly mistake really.

See the latest commit for why… oops!

On 30 Mai 2014, at 02:17, Rob McBroom notifications@github.com wrote:

Hmmm. Have you tried clearing caches and running this? Preference Panes look good, but I was going to test Fast Logout.sh and the Extra Scripts aren’t getting indexed at all. I’ll try to figure out why if I have time later.


Reply to this email directly or view it on GitHub.

There was confusion over using the keys and the similarly named (but now-unused) variables
E.g. URLIsDirectory vs. NSURLIsDirectoryKey
@pjrobertson
Copy link
Member Author

pjrobertson commented May 30, 2014

P.S. is it just me, or is file browser now blazingly faster? That needs to go in the changelog ;-)

@skurfer
Copy link
Member

skurfer commented May 30, 2014

Cool. I’ve merged this into my day-to-day build. I’ll try it for a while, but don’t see any issues now.

As for speed, I can’t tell much of a difference, but it certainly isn’t slow. (I usually check by arrowing into /usr/bin/.)

@pjrobertson
Copy link
Member Author

pjrobertson commented May 30, 2014

Yep, it’ll need some testing. Since QSUTIWithLSInfoRec and NSURL’s NSURLTypeIdentifierKey give different values for the “Fast Logout.sh” script, I have no doubt that there will be discrepancies in other places.

But hopefully, any discrepancies will be for the better

On 30 Mai 2014, at 10:43, Rob McBroom notifications@github.com wrote:

Cool. I’ve merged this into my day-to-day build. I’ll try it for a while, but don’t see any issues now.

As for speed, I can’t tell much of a difference, but it certainly isn’t slow. (I usually check by arrowing into /usr/bin/.)


Reply to this email directly or view it on GitHub.

skurfer added a commit that referenced this issue May 30, 2014
@skurfer skurfer merged commit 6aed887 into master May 30, 2014
1 check was pending
@skurfer skurfer deleted the aliases branch May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants