More Type Changes

[skurfer]

Following from #1740…

While looking at another issue, I ran across some places where it looked like the pasteboard types and QS types were still assumed to be the same thing.

If it looked like a type for the pasteboard or drag & drop, I left it alone. If it dealt with keys in QSObject data dictionary, I changed it.

Other small things:

• use string value in the Type Text action
• use display name in the descriptive string for commands
• if no actions are found, log the object we were checking, not the list of all actions

[skurfer]

There was one other place in QSGlobalSelectionProvider that needs fixing, but it conflicted with the Finder proxy branch, so I took it out and rebased this. That instance is already fixed over there.

[skurfer]

Added another commit to address #1777. I think * deserves to be a special case. (Maybe an empty string should be too? I saw some actions being added for the type "").

In the end, this should probably return the UTI public.item, but I don’t know if we’re quite there yet. We’d probably have to do something similar to what we did for files and text. That is, convert * to public.item when reading in property lists.

[pjrobertson]

see this is where things get horrible. The 'old' way of doing pasteboard stuff (which we're still using) uses the NSStringPboardType things. The 'new' way (which I was trying to convert to) uses UTIs exclusively (trying to use a non-UTI (a.k.a. NSStringPboardType breaks things)

I'm not sure what the repercussions of using a UTI with the 'old' way is, but if it works, then it's a step in the right direction. I'll take a look

[pjrobertson]

Nevermind, this will all be irrelevant when I get my fancy 10.6+ pasteboard stuff out. Since initWithPasteboard... a few lines above is using QSTextType then you've done the right thing here :)

[pjrobertson]

Looks fine by me. Will run with it for a bit

[skurfer]

I think this will conflict with your fixes in QSObject_Pasteboard.m, but it’s easy to fix. (Just take the changes from the other branch.)

[pjrobertson]

yeah, I've just merged everything into one nice branch, along with my 10.6+ pasteboard stuff (so all this is obsolete now) and I saw that one. Only a minor thing on NSStringPboardType