Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the automator actions #1786

Merged
merged 5 commits into from Mar 13, 2014
Merged

Update the automator actions #1786

merged 5 commits into from Mar 13, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 28, 2014

Fixes #915

Changes:

  • Use the .xcconfig files from the main project
  • Rebuild for x86_64
  • Upgrade .xcodeprojs
  • Fix any warnings

Says it all really. After import the 'configuration' folder, all I did was hit 'build' and everything was updated for me :)

Oh - now I think about it. The should probably be build by @skurfer and code signed :)
It should be pretty simple. The build phases even move the build products to the right folder!

Fixes #915

Changes:
* Use the .xcconfig files from the main project
* Rebuild for x86_64
* Upgrade .xcodeprojs
* Fix any warnings
@skurfer
Copy link
Member

@skurfer skurfer commented Feb 28, 2014

I can’t get anything to work in Automator, but I don’t really know what I’m doing. I even tried building them signed in case that matters and saw the same results.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 3, 2014

Why did you have to test it eh? :P

I’ve just tried and I can confirm that things are screwy. I’ve looked it over and can’t figure out why (I know just as much about automator actions as you). I’ll have to learn I guess :)

On 1 Mawrth 2014, at 03:09, Rob McBroom notifications@github.com wrote:

I can’t get anything to work in Automator, but I don’t really know what I’m doing. I even tried building them signed in case that matters and saw the same results.


Reply to this email directly or view it on GitHub.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 4, 2014

I’ve figured out how to debug Automator actions (all the docs are for Xcode 3) so I’m on my way. I’ll get there soon enough ;-)

On 3 Mawrth 2014, at 09:50, Patrick Robertson robertson.patrick@gmail.com wrote:

Why did you have to test it eh? :P

I’ve just tried and I can confirm that things are screwy. I’ve looked it over and can’t figure out why (I know just as much about automator actions as you). I’ll have to learn I guess :)

On 1 Mawrth 2014, at 03:09, Rob McBroom notifications@github.com wrote:

I can’t get anything to work in Automator, but I don’t really know what I’m doing. I even tried building them signed in case that matters and saw the same results.


Reply to this email directly or view it on GitHub.

pjrobertson added 2 commits Mar 11, 2014
When using the helper/block method arrayByEnumeratingArrayUsingBlock
Fixes the Automator actions, and removes redundant/confusing code.
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 11, 2014

OK, see my commits.

I've changed things round a bit... seems like Apple's support for AppleScript if getting more and more flaky. Instead of advertising that QS sends/receives Apple Event objects, I just specified some 'special' Cocoa types. (See the Automator docs for more info - search for 'Automator Action Property Reference' and go to the first 'SDK Guides' result)

This also affects how the AppleScript:

tell application "Quicksilver"
set qsSelection to selection
-- do something
end tell

works, but I've tested it and it still works fine. Might be worth somebody else testing it as well though.
Both Get and Set automator actions should be good to go

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 11, 2014

Still getting errors, but maybe Launch Services hasn’t seen the changes? I rebuilt both actions, but Git doesn’t show any differences. Have they not changed at all? (I didn’t see them updated the second commit, either, so maybe they haven’t changed.)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 11, 2014

Yeah you’ll probably need to wipe all other QS versions of your computer. I’ve set up the schemes to be shared, so you should be able to debug now (under Debug). Running the Automator action will launch Automator with the correct actions. As long as you only have one debug QS running (from the automator branch) then it should work fine

On 11 Mawrth 2014, at 21:07, Rob McBroom notifications@github.com wrote:

Still getting errors, but maybe Launch Services hasn’t seen the changes? I rebuilt both actions, but Git doesn’t show any differences. Have they not changed at all? (I didn’t see them updated the second commit, either, so maybe they haven’t changed.)


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 12, 2014

Found more information on the console.

2014/03/12 9:27:29.041 AM Automator[635]: Error in __36-[AMImageRegistry imageForURL:size:]_block_invoke: The file “Quicksilver.app” couldn’t be opened because there is no such file.

I’m not sure where it’s looking, but I’ve removed everything but the copy in /Applications and that has the updated actions.

This also happens if I try to Build & Run in Xcode, as described by Mac OS X Automation.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 12, 2014

Yeah I saw that strange thing in Console.app. Couldn’t figure it out. I think clearing derived data and restarting Xcode may have helped with that, I’m not too sure.
What you linked to is what I set up in the shared schemes. Did they not show up for you after my latest push? Hmm…. I will jump on Colloquy now to chat if you’re about

On 12 Mawrth 2014, at 21:35, Rob McBroom notifications@github.com wrote:

Found more information on the console.

2014/03/12 9:27:29.041 AM Automator[635]: Error in __36-[AMImageRegistry imageForURL:size:]_block_invoke: The file “Quicksilver.app” couldn’t be opened because there is no such file.
I’m not sure where it’s looking, but I’ve removed everything but the copy in /Applications and that has the updated actions.

This also happens if I try to Build & Run in Xcode, as described by Mac OS X Automation.


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 12, 2014

OK, I was missing the last commit for some reason. Deleted my schemes, and built with the shared ones. I found that they end up in /tmp/QS/build/Release, but when you build the application, it doesn’t look for them there. So I copied them into place (and then Git saw them as different), built the app, deleted other copies and tried again. I opened each action again, which prompted me to overwrite existing ones this time, so I took that as a good sing.

Then, same error, but…

I started typing a message here, but wanted to verify that it wasn’t actually a different error in case that would be useful, so I launched Automator for another try and suddenly, the actions started working!

So, you got them working. 🎉 The remaining task is to make sure they work for others.

  1. I think I should commit the new copies of the actions I just built to the repo (or you can build them and copy them into place).
  2. I think I’ve verified this, but “installing” the actions manually won’t be necessary for everyone, right? I just deleted them from ~/Library/Automator and then dropped a new copy of Quicksilver in /Applications and they seem to have reappeared (and still work).

Plus: update Info.plist with up-to-date version numbers/copyrights
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 13, 2014

Yay, so you got it working! The actions shouldn't need to be in the QS app for our debugging purposes (since we're defining -action /path/to/Get Selection.action in the build arguments) - it's strange that it only worked after that for you. But oh, well - it's working now.

You're right the newly build apps should be copied to the right place. I've updated them now (along with the info.plist)

Finally, there should be no need to install the actions. Automator automatically scans bundles.
If a user has installed them, then they probably want to delete them.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 13, 2014

Great. Looks like it all works now.

skurfer added a commit that referenced this issue Mar 13, 2014
@skurfer skurfer merged commit f69f913 into master Mar 13, 2014
1 check passed
@skurfer skurfer deleted the automator branch Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants