Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent the plug-in updater from going off screen #1797

Merged
merged 2 commits into from Mar 18, 2014
Merged

prevent the plug-in updater from going off screen #1797

merged 2 commits into from Mar 18, 2014

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Mar 14, 2014

Another quickie for 1.2.0

One way to test is to downgrade all plug-ins. Here’s a script that will do it.

#!/usr/bin/env python

import os
from plistlib import readPlist, writePlist

plugin_path = '/path/to/copy/of/PlugIns'
for fitem in os.listdir(plugin_path):
    if fitem.endswith('.qsplugin'):
        plist_path_parts = [plugin_path, fitem, 'Contents', 'Info.plist']
        plist_path = '/'.join(plist_path_parts)
        data = readPlist(plist_path)
        current_version = data['CFBundleVersion']
        version = hex(int(current_version, 16) - 1)[2:]
        data['CFBundleVersion'] = version.upper()
        writePlist(data, plist_path)

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented on 2aba729 Mar 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit looks good. Can you just change the comment on line 48/49 to read:

111 is the 'extra'...

instead of 121.

Then feel free to merge :)

skurfer
Copy link
Member Author

@skurfer skurfer commented on 2aba729 May 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in version 1.2.0 (which is currently just a pre-release), but that has some other outstanding issues you probably don’t want to deal with.

There’s no good way out of this, so I just created a special build. It should be identical to 1.1.3, but with the fix for the plug-in updater included. Download it from the link below and give it a shot. After you unzip it, quit Quicksilver and replace your copy with this one. (This build should be signed so Gatekeeper won’t complain.)

http://cl.ly/0A030c0E0a3A

skurfer
Copy link
Member Author

@skurfer skurfer commented on 2aba729 May 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I do something wrong during install?

No, but since you’re starting from scratch, you’ll probably want to go to Preferences → Actions and drag things up/down to suit your needs. This should be a one-time step.

For starters, you’ll want “Search For…” to be higher on the list than “Open URL”. Actually, that might already be the case, but that Search URL looks a little strange. (It should be more like http://www.google.com/search?q=***.) Do you have any idea where in your catalog that’s coming from?

skurfer
Copy link
Member Author

@skurfer skurfer commented on 2aba729 May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, well there are 100 ways to get search URLs into the catalog. I won’t overload you with all of them. You probably want either the pre-defined ones, or to make your own list if they add too much noise (which is covered in the manual).

First, see if you have any of the pre-defined ones enabled. Go to Preferences → Catalog → Plugins. There should be two entries starting with “Web Searches”. Is either enabled? If so, you should have one named “Google (US)” in your catalog. Try typing “goog” and hitting until you see it. The details at the bottom of the Quicksilver interface should contain *** somewhere.

skurfer
Copy link
Member Author

@skurfer skurfer commented on 2aba729 May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two entries beginning with "Web Searches." (pic 1) I don't see anything indicating Google (US.)

See the 26 next to “Web Searches (Simple)”? It should be one of those. There’s a way to see them, but it’s not important.

FYI, “Web Searches (Full List)” includes everything from the “Simple” entry, so there’s no need to enable both. (But you probably only want the simple list.)

I tried manually typing in "(docs.blacktree.com)" and deleting "(simple)" on the second entry. The app crashed. (pic 2)

That’s just a name. It doesn’t affect functionality. And I don’t think you can change it since that’s a preset provided by a plug-in.

Could either issues in pic 3 & pic 4 be the cause of the issue?

Pic 3 is from the Remote Hosts plug-in. You can read its documentation to see what it’s about, but it’s not relevant here.

Pic 4 shows a custom collection of web searches you’ve added, but you haven’t put anything in it. You can use a custom list of searches in addition to, or instead of, one of the built-in lists. But having an empty list there shouldn’t hurt anything.

As for the order of the actions, I think “Search for…” only appears under “All Actions”, not under “URLs”. Make sure “Search For…” is higher than “Open URL”.

When I said to look for “Google (US)”, I didn’t mean in the preferences. Just call up the Quicksilver interface like you normally would and type “goog”. According to pic 1, the searches are being added to your catalog, so you should be able to find it.

skurfer
Copy link
Member Author

@skurfer skurfer commented on 2aba729 May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the results when I type "Google (US)."

OK, good. That’s the thing you’re looking for. The remaining issue is that “Search For…” isn’t coming up as the default action. You should be able to fix that by going to Preferences → Actions and reordering things. (You can safely drag “Search For…” all the way to the top if you want. It only applies to search URLs, so it won’t appear in other contexts.)

Is this supposed to help the "open Url/create file" issue? I disabled Web Searches (Full List) and the "open URL" is still defaulting to 'create file.’

This could be a problem with URLs beginning with qss-http:// that aren’t valid searches. I’ll look into that. But you shouldn’t run across those normally. I’m not sure how you were getting to them or where they were coming from. We can dig into that if you want, but if you stick to the searches supplied by the plug-in (and adjust the default action), it shouldn’t be a problem any more.

DerekCurrie
Copy link

@DerekCurrie DerekCurrie commented on 2aba729 Sep 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skurfer: You just closed out my bug report of this ONGOING bug in the latest/current public version of QuickSilver. I dug around to comprehend exactly why, and I found this page. It indicates that this bug indeed has not been solved, at least in public. Instead, it is being sat upon within unreleased version 1.2.0.

I hope you understand that the 'workaround' listed in #1769 is specifically listed at NOT working in QuickSilver windows and is therefore NOT actually a workaround. Therefore, those of us caught in the jaws of this bug have no solution.

Could QuickSilver version 1.2.0 please be finished and released in order to solve this bug?

In the meantime, while the thumb twiddling here continues, I'm going to entirely uninstall QuickSilver and start from scratch, the only real 'workaround'.

skurfer
Copy link
Member Author

@skurfer skurfer commented on 2aba729 Sep 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just closed out my bug report of this ONGOING bug in the latest/current public version of QuickSilver.

Mostly because it was a duplicate of known issue. Reasonable people can disagree on whether or not the original should be closed.

Could QuickSilver version 1.2.0 please be finished and released in order to solve this bug?

I hope so. I’m just waiting on a one-line change (#1931) to get approved.

skurfer added a commit that referenced this issue Mar 18, 2014
prevent the plug-in updater from going off screen
@skurfer skurfer merged commit 24d17b9 into master Mar 18, 2014
1 check was pending
@skurfer skurfer deleted the updaterheight branch Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants