Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the AppleScript warning at launch about list. #1810

Merged
merged 1 commit into from Apr 11, 2014
Merged

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Mar 29, 2014

I found the fix almost 1 year and an half after I stopped looking ;-).

Note that I haven't checked for breakage, the rationale being that it was already broken but working I'm lazy, and I don't have scripts handy.

I found the fix almost 1 year and an half after I stopped looking ;-).
@skurfer
Copy link
Member

@skurfer skurfer commented Mar 31, 2014

I thought @pjrobertson fixed that a while ago, though I do still see it.

I tested it with one of the scripts in the Wiki that uses get direct types. Seems to work, but I’ll give @pjrobertson some time to chime in before merging.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 11, 2014

Yeah, I thought I'd fixed it (commit dc5f722 ) - but obviously I hadn't. Looking at it, seems I changed the scriptSuite file as opposed to the sdef file. Seems the Suite file is generated from the sdef file, so that's the one that needed changing.

Oops :/

pjrobertson added a commit that referenced this issue Apr 11, 2014
Remove the AppleScript warning at launch about `list`.
@pjrobertson pjrobertson merged commit c2838e6 into master Apr 11, 2014
1 check passed
@pjrobertson pjrobertson deleted the fix-as-warning branch Apr 11, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants