Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few inspired things #1828

Merged
merged 2 commits into from Apr 20, 2014
Merged

A few inspired things #1828

merged 2 commits into from Apr 20, 2014

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Apr 19, 2014

This is in response to http://superuser.com/questions/743170/how-can-i-concatenate-multiple-clipboard-selections-in-quicksilver

Also tried to fix a few warnings, but given that there's an interesting note in NSPanel.h about it being deprecated, I stopped. We have QSAlertManager, and I was wondering if we could move our alert-building methods there (it's painful to allocate and set up in the Apple-sanctioned way now), as well as our Notification Center stuff (I have a feeling some things like the update system alerts would be better as notifications). Opinions ?

skurfer added a commit that referenced this pull request Apr 20, 2014
@skurfer skurfer merged commit 04d2add into master Apr 20, 2014
@skurfer skurfer deleted the t/minor-things branch Apr 20, 2014
@skurfer
Copy link
Member

skurfer commented Apr 20, 2014

The changes look good (obviously).

I agree with making all the update-related dialogs less intrusive, but I don’t see the connection to warnings. Can you elaborate on what you want to change? (Maybe just open an issue describing what you want to do and assign the 2.0.0 milestone to it.)

@tiennou
Copy link
Member Author

tiennou commented Apr 21, 2014

The warning is the one about "non-static string used in a format specifier". But obviously we're trying to have localization involved, and thus the string can never be static. Since the NSPanel functions all take care of formatting their message, it's a dead-end, so the thing is now deprecated, and NSAlert must be used. Except that NSAlerts must be built by hand, which changes a 1 line (okay long line) function call in a 6+ object setup.

So I might rework QSAlertManager (since it's not used for anything except 1 call) to have a nicer API around NSAlert, and handle NSUserNotification too (since they are closely related). Or make the Update Manager use Notification Center, whichever comes first ;-).

@slambert
Copy link

slambert commented May 3, 2014

Hi, I posted the question on superuser. This is exciting. Is it in a public release so I can check it out? And how would I use it?

Thanks so much. I've been a grateful QS user for close to 10 years I think…

@skurfer
Copy link
Member

skurfer commented May 5, 2014

Is it in a public release so I can check it out?

Not yet. It will be in the next preview of 1.2.0 (build 400B).

And how would I use it?

Select multiple items from your clipboard history (or any other text item), then run the “Type Text” action. This isn’t really pasting, so it won’t work with images or rich text, but it should do the trick for plain text.

For reasons I don’t recall, running the Paste action with multiple items would crash Quicksilver, so the ability to do that has been disabled for now.

@slambert
Copy link

slambert commented May 14, 2014

Great. Posted back on superuser. Thanks! Honored to have the scratch of my little itch included in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants