Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference to restart automatically without crash reporter #1837

Closed

Conversation

clarkewd
Copy link

@clarkewd clarkewd commented May 13, 2014

No description provided.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented May 13, 2014

Can one of the admins verify this patch?

@clarkewd
Copy link
Author

@clarkewd clarkewd commented May 13, 2014

I'm not sure what the review process is for pull requests, but because it may not be apparent from the "files changed" section ( the .xib diff is suppressed ), this commit also adds a GUI checkbox in preferences:

However, since most of the advanced preferences need to now be set via the command line I would be OK if this was not GUI toggle-able.

However, as a side note, I think a lot of QS users are "power users" and so it might make sense (at some point) to put the "hidden default" preferences back into the application, maybe via an "advanced" preferences area, to make testing, debugging, and just keeping up with all of them easier:

( that is not part of this simple pull request though )

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 14, 2014

simple enough change, but should we make it so that ticking the box automatically sends the crash reports to us? This way, we'll be losing a lot of crash reports (not that we're using them much at the moment)

@clarkewd
Copy link
Author

@clarkewd clarkewd commented May 14, 2014

possibly but it would require some rate limiting i think, otherwise it could be a continuous restart loop - so a lot of crash logs

@skurfer
Copy link
Member

@skurfer skurfer commented May 14, 2014

I don’t think it should say “restart automatically” anywhere, since you still have to restart it yourself. Maybe it should say “Report crashes automatically when restarting” or something like that.

@clarkewd
Copy link
Author

@clarkewd clarkewd commented May 14, 2014

Good call. I'm using a LaunchAgent with KeepAlive so for me it does restart automatically, but for others it would not. That would also mean we could have it send error reports automatically when that preference was enabled, or maybe we could have another preference for the error reporting.

@skurfer
Copy link
Member

@skurfer skurfer commented May 14, 2014

As long as we’re changing stuff, what about adding an e-mail address to the error reports (see TextMate 2 for an example). More than once, I’ve wanted to ask the submitter a question.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jul 30, 2014

ok to test

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 30, 2014

I think perhaps the best bet would be to keep this as a hidden preference? So include all your changes here @clarkewd - but just remove the changes to the Preferences pane.

I agree @skurfer - an email address field would be good. I think just changing the placeholder text to something like "Provide any steps necessary to reproduce the problem. Please provide you're email address if you're happy for us to contact you"

@clarkewd
Copy link
Author

@clarkewd clarkewd commented Sep 30, 2014

I did a different pull request as it seemed cleaner to not have committed code and then have that code removed, for a change involving only a few lines.

@skurfer skurfer closed this Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants