Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 2 fixes #1839

Merged
merged 4 commits into from May 16, 2014
Merged

V1 2 fixes #1839

merged 4 commits into from May 16, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 15, 2014

Silly GH posted my commit before I could type anything.

...we're not out of the woods yet with v1.2 :(

The lone crash report on the server today is with the simple notifier. It seems it was still using CGSPrivate. I removed that, and now it works (but doesn't do the cube rotation)

In the meantime I fixed CGSPrivate so it doesn't crash things, but it still looks ugly.

@skurfer
Copy link
Member

@skurfer skurfer commented May 15, 2014

That’s why it’s a pre-release. 😃 Is that third commit a repeat?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented May 15, 2014

I made a similar CA_uncommitted_transaction commit in 8164401, but they're both valid

The iconLoadedSet is only ever accessed in two places.
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented May 16, 2014

The latest commit fixes a crash on the server.

Another crash present is relating to the Cube interface:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.CoreGraphics              0x00007fff8ad2e865 CGSNewTransition + 215
1   com.blacktree.QSEffects             0x0000000108d11acd +[QSCGSTransition transitionWithWindow:type:option:] + 100
2   com.blacktree.Quicksilver.QSCubeInterfacePlugIn     0x000000010d850645 0x10d84d000 + 13893
3   com.blacktree.QSEffects             0x0000000108d1417e -[QSWindow makeFirstResponder:] + 237
4   com.apple.AppKit                    0x00007fff88a857f2 -[NSWindow selectKeyViewFollowingView:] + 171
5   com.apple.AppKit                    0x00007fff88a85ad0 -[NSWindow selectNextKeyView:] + 315
6   com.blacktree.QSInterface           0x0000000108e017a4 -[QSSearchObjectView insertTab:] + 81

Seems like doing the dance with the Cube plugin hasn't worked in this case. Since my 1st commit should stop the crash (but the transition is still ugly) then that should be enough 'fix this bug'

skurfer added a commit that referenced this issue May 16, 2014
@skurfer skurfer merged commit a168ea4 into master May 16, 2014
1 check passed
@skurfer skurfer deleted the v1_2_fixes branch May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants