Crash fixes #1860
Merged
Crash fixes #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1848 If you selected a non-editable trigger set (e.g. iTunes) then tried to add a trigger QS would crash
Setting the activation hotkey before QS had properly finished launching can cause problems esp. when trying to change input sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The first fixes #1848
I dan't believe it was never brought up before
The 2nd fixes a crash I've just been experiencing since I enabled the "switch input type when activating QS" pref.
I can't believe that this was never brought up before either! :P
That is - enabling the hotkey before QS has even finished setting up properly is bound to cause problems. I'm hoping that my change may also stop lots of the EXC_BAD_ACCESS crashes I get (and presumably others) in
QSLibwhen just launching QS and not doing anything in particular.