Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash fixes #1860

Merged
merged 2 commits into from Jun 1, 2014
Merged

Crash fixes #1860

merged 2 commits into from Jun 1, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 31, 2014

The first fixes #1848
I dan't believe it was never brought up before

The 2nd fixes a crash I've just been experiencing since I enabled the "switch input type when activating QS" pref.
I can't believe that this was never brought up before either! :P
That is - enabling the hotkey before QS has even finished setting up properly is bound to cause problems. I'm hoping that my change may also stop lots of the EXC_BAD_ACCESS crashes I get (and presumably others) in QSLib when just launching QS and not doing anything in particular.

pjrobertson added 2 commits May 31, 2014
Fixes #1848
If you selected a non-editable trigger set (e.g. iTunes) then tried to add a trigger QS would crash
Setting the activation hotkey before QS had properly finished launching can cause problems
esp. when trying to change input sources
skurfer added a commit that referenced this issue Jun 1, 2014
@skurfer skurfer merged commit 90d13b8 into master Jun 1, 2014
1 check was pending
@skurfer skurfer deleted the crashFixes branch Jun 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants