Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dragging/dropping multiple files in QS #1874

Merged
merged 1 commit into from Jun 11, 2014
Merged

Fix for dragging/dropping multiple files in QS #1874

merged 1 commit into from Jun 11, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 11, 2014

Fixes #1866

So public.file-url data on the pasteboard can only hold the info for ONE file copied/dragged. We still need to use NSFilenamesPboardType. Even Finder does this: drag 2 files from finder; the pasteboard data for public.file-url refers to one of the files only, and the NSFilenamesPboardType refers to both

@@ -346,7 +346,7 @@ - (BOOL)objectHasValidChildren:(QSObject *)object {

- (NSDragOperation)operationForDrag:(id <NSDraggingInfo>)sender ontoObject:(QSObject *)dObject withObject:(QSBasicObject *)iObject {
if (![iObject arrayForType:QSFilePathType])
return 0;
return NSDragOperationNone;
Copy link
Member Author

@pjrobertson pjrobertson Jun 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two things are the same. Just it's better to use the actual name/const

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 11, 2014

Seems to work as advertised, and um… all the test pass, for what that’s worth. 😉

skurfer added a commit that referenced this issue Jun 11, 2014
Fix for dragging/dropping multiple files in QS
@skurfer skurfer merged commit 32761a3 into master Jun 11, 2014
1 check was pending
@skurfer skurfer deleted the pasteboardDrag branch Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants