Fix for dragging/dropping multiple files in QS #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -346,7 +346,7 @@ - (BOOL)objectHasValidChildren:(QSObject *)object { | |||
|
|
|||
| - (NSDragOperation)operationForDrag:(id <NSDraggingInfo>)sender ontoObject:(QSObject *)dObject withObject:(QSBasicObject *)iObject { | |||
| if (![iObject arrayForType:QSFilePathType]) | |||
| return 0; | |||
| return NSDragOperationNone; | |||
There was a problem hiding this comment.
These two things are the same. Just it's better to use the actual name/const
|
Seems to work as advertised, and um… all the test pass, for what that’s worth. |
skurfer
added a commit
that referenced
this issue
Jun 11, 2014
Fix for dragging/dropping multiple files in QS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #1866
So
public.file-urldata on the pasteboard can only hold the info for ONE file copied/dragged. We still need to useNSFilenamesPboardType. Even Finder does this: drag 2 files from finder; the pasteboard data forpublic.file-urlrefers to one of the files only, and theNSFilenamesPboardTyperefers to both