Resultcontroller tweaks

[pjrobertson]

So a few small things included here, only one of which is really required for v1.2.0 - that being the switch to run the showMainWindow block synchronously (GCD). Doing it async was causing all sorts of interface problems, such as the result window details not updating properly
(You can produce the problem in any 1.2.0 pres by making sure the result window is always shown, then searching. You'll notice that ever time you press a key, the details at the bottom of the result window shows the last selected object)

The rest is just an attempt to refresh the window. Improve alignment, etc.

[skurfer]

Looks nicer. Seems to fit with a particular interface. 😃

Are we going to #1838 for the time being?

[pjrobertson]

Hmmm... I thought I posted a reply here. Must have not got through.

Take a look at the pull now. The only thing I haven't fixed (and can't, and won't) is the ghost text in the result table when you have opacity set.

[skurfer]

Hmmm. I can’t get the interface to appear at all using this branch. Could it be the firstResponder changes?

[pjrobertson]

Strange. Can you debug?
If by firstResponder changes you mean this - that's just a class convenience method for getting the first responder. Means you don't always have to type (and cast etc.) the whole thing every time

[skurfer]

OK. I just skimmed the diff looking for what might explain it. Didn’t go very deep, obviously. Time is short, but I’ll try to debug, yeah.

[pjrobertson]

My bad, I'd only been testing with the result child table visible. Disabling it makes it nil and caused an exception (adding nil to an array). Fixed now.

Duh

[skurfer]

So a few small things included here, only one of which is really required for v1.2.0 - that being the switch to run the showMainWindow block synchronously (GCD). Doing it async was causing all sorts of interface problems, such as the result window details not updating properly

You mean arrayChanged is no longer async? It looks like showMainWindow still is. In any case, the bug you described appears to be fixed. Feel free to merge this if there’s nothing to my question. 😃

[pjrobertson]

Yep, I meant ‘arrayChanged’ is no longer async. ‘showMainWindow’ probably shouldn’t be Async either…

I’ll leave it for now. C’mon 1.2.0. Get out the door!

On 19 Meh 2014, at 09:57, Rob McBroom notifications@github.com wrote:

So a few small things included here, only one of which is really required for v1.2.0 - that being the switch to run the showMainWindow block synchronously (GCD). Doing it async was causing all sorts of interface problems, such as the result window details not updating properly

You mean arrayChanged is no longer async? It looks like showMainWindow still is. In any case, the bug you described appears to be fixed. Feel free to merge this if there’s nothing to my question.

—
Reply to this email directly or view it on GitHub.