Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resultcontroller tweaks #1877

Merged
merged 8 commits into from Jun 19, 2014
Merged

Resultcontroller tweaks #1877

merged 8 commits into from Jun 19, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 11, 2014

So a few small things included here, only one of which is really required for v1.2.0 - that being the switch to run the showMainWindow block synchronously (GCD). Doing it async was causing all sorts of interface problems, such as the result window details not updating properly
(You can produce the problem in any 1.2.0 pres by making sure the result window is always shown, then searching. You'll notice that ever time you press a key, the details at the bottom of the result window shows the last selected object)

The rest is just an attempt to refresh the window. Improve alignment, etc.

* Fix to make sure the details string always shows the right results
* Better spacing of icons in the result table
* Remove the gradient header/footer
* Make the dot icon bigger
* Use Autolayout - better for resizing.
* Nudge things around a little
@skurfer
Copy link
Member

@skurfer skurfer commented Jun 12, 2014

Looks nicer. Seems to fit with a particular interface. 😃

Are we going to #1838 for the time being?

pjrobertson added 6 commits Jun 17, 2014
Allow opacity - fixes #1838
Better binding of colours / DRY
Fix for the result child table styles
Allow changing the header/footer text color
Conflicts:
	Quicksilver/Code-QuickStepInterface/QSResultController.m
	Quicksilver/Code-QuickStepInterface/QSSearchObjectView.m
Results list still not fixed
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 17, 2014

Hmmm... I thought I posted a reply here. Must have not got through.

Take a look at the pull now. The only thing I haven't fixed (and can't, and won't) is the ghost text in the result table when you have opacity set.

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 17, 2014

Hmmm. I can’t get the interface to appear at all using this branch. Could it be the firstResponder changes?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 17, 2014

Strange. Can you debug?
If by firstResponder changes you mean this - that's just a class convenience method for getting the first responder. Means you don't always have to type (and cast etc.) the whole thing every time

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 17, 2014

OK. I just skimmed the diff looking for what might explain it. Didn’t go very deep, obviously. Time is short, but I’ll try to debug, yeah.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 18, 2014

My bad, I'd only been testing with the result child table visible. Disabling it makes it nil and caused an exception (adding nil to an array). Fixed now.

Duh

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 19, 2014

So a few small things included here, only one of which is really required for v1.2.0 - that being the switch to run the showMainWindow block synchronously (GCD). Doing it async was causing all sorts of interface problems, such as the result window details not updating properly

You mean arrayChanged is no longer async? It looks like showMainWindow still is. In any case, the bug you described appears to be fixed. Feel free to merge this if there’s nothing to my question. 😃

pjrobertson added a commit that referenced this issue Jun 19, 2014
@pjrobertson pjrobertson merged commit 1cb312b into master Jun 19, 2014
1 check was pending
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 19, 2014

Yep, I meant ‘arrayChanged’ is no longer async. ‘showMainWindow’ probably shouldn’t be Async either…

I’ll leave it for now. C’mon 1.2.0. Get out the door!

On 19 Meh 2014, at 09:57, Rob McBroom notifications@github.com wrote:

So a few small things included here, only one of which is really required for v1.2.0 - that being the switch to run the showMainWindow block synchronously (GCD). Doing it async was causing all sorts of interface problems, such as the result window details not updating properly

You mean arrayChanged is no longer async? It looks like showMainWindow still is. In any case, the bug you described appears to be fixed. Feel free to merge this if there’s nothing to my question.


Reply to this email directly or view it on GitHub.

@pjrobertson pjrobertson deleted the resultcontroller_tweaks branch Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants