Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the LaunchAtLoginController code Fixes #1893 #1894

Merged
merged 3 commits into from Jul 23, 2014
Merged

Update the LaunchAtLoginController code Fixes #1893 #1894

merged 3 commits into from Jul 23, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 23, 2014

Returning CF types from an Obj-C method always seems a bit funny, so I changed the problematic method to a C function, and renamed it to follow the Obj-C naming conventions.

You should probably take a look at my commit on the LaunchAtLoginController repo whilst you're at it.
I merged the two of the 3 outstanding pull requests on the original LALC repo before making my changes (although they weren't very well written anyway)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jul 23, 2014

Ooops, I fixed my silly memory leak in an additional commit on the LALC repo

@skurfer
Copy link
Member

@skurfer skurfer commented Jul 23, 2014

Nice and crash free.

skurfer added a commit that referenced this issue Jul 23, 2014
Update the `LaunchAtLoginController` code Fixes #1893
@skurfer skurfer merged commit e0eb74f into master Jul 23, 2014
1 check passed
@skurfer skurfer deleted the i1893 branch Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants