Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow status icon to work with dark mode #1940

Merged
merged 1 commit into from Oct 8, 2014
Merged

allow status icon to work with dark mode #1940

merged 1 commit into from Oct 8, 2014

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Oct 6, 2014

One last thing for 1.2.0 to support Yosemite.

normal: kinda blurry and crappy
normal w/ retina: looks good
dark mode: looks good
dark mode w/ retina: unable to test yet

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 6, 2014

Is this a kind of 'quick fix' that looks alright?

From the docs (which it seems we aren't doing)

Template images are not intended to be used as standalone images. They are always mixed with other content and processed to create the desired appearance. You can mark an image as a “template image” to notify clients who care that the image contains only black and clear content. The most common use for template images is in image cells. For example, you might use a template image to provide the content for a button or segmented control. Cocoa cells take advantage of the nature of template images—that is, their simplified color scheme and use of transparency—to improve the appearance of the corresponding control in each of its supported states.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 7, 2014

I think it’s the actual fix. Apple’s documentation appears to be silent on the subject (or I don’t know what to search for), so I went with random Internet recommendations. 😃 I think this counts as not using the image directly. It’s more of a mask.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 8, 2014

Did some more research and I think this is an acceptable answer until we drop 10.9.

See http://stackoverflow.com/a/24644754/491598

Although, ideally, we would clean up the “template” images a little. I spent some time on it, only to make it look worse.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 8, 2014

Good :)

pjrobertson added a commit that referenced this issue Oct 8, 2014
allow status icon to work with dark mode
@pjrobertson pjrobertson merged commit e8e315f into master Oct 8, 2014
0 of 2 checks passed
@pjrobertson pjrobertson deleted the darkmode branch Oct 8, 2014
skurfer added a commit that referenced this issue Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants