Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dispatch_release call #1955

Merged
merged 1 commit into from Nov 1, 2014
Merged

remove dispatch_release call #1955

merged 1 commit into from Nov 1, 2014

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Oct 20, 2014

From glancing at the documentation, it looks like we shouldn’t be doing this under ARC.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2014

I'm not sure, but looking at the docs here 1 I'm worried this change won't work for 10.7.

The docs say that dispatch objects are only obj-c objects from 10.8 onwards, so we would probably need this for 10.7

Hows about we drop 10.7 in the next release - could do it as part of this pull I s'pose ;)

[1] - xcdoc://?url=developer.apple.com/library/etc/redirect/xcode/mac/eba9e1/documentation/Performance/Reference/GCD_libdispatch_Ref/Reference/reference.html

@pjrobertson pjrobertson mentioned this pull request Oct 27, 2014
@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 27, 2014

Hows about we drop 10.7 in the next release

Should have been done for 1.2.0 if you ask me. 😃

@skurfer
Copy link
Member Author

@skurfer skurfer commented Nov 1, 2014

Merged the other thing, so this should be safe now.

pjrobertson added a commit that referenced this issue Nov 1, 2014
remove `dispatch_release` call
@pjrobertson pjrobertson merged commit c569a33 into master Nov 1, 2014
0 of 2 checks passed
@pjrobertson pjrobertson deleted the i1953 branch Nov 1, 2014
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 1, 2014

Nice

skurfer added a commit that referenced this issue Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants