Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset modifier only hotkey activation between key presses #1969

Merged
merged 1 commit into from Nov 1, 2014

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 1, 2014

If a different modifier was pressed between two 'activation modifier' key presses, QS could still be activated.
E.g. in a 'double shift activation' scenario, if ⇪⌥⇧ was pressed, QS would still activate.
This change ensures that the state of any modifier events is reset when any non-related keys are pressed.

Fixes #1950

If a different modifier was pressed between two 'activation modifier' key presses, QS could still be activated.
E.g. in a 'double shift activation' scenario, if ⇪⌥⇧ was pressed, QS would still activate.
This change ensures that the state of any modifier events is reset when any non-related keys are pressed.

Fixes #1950
skurfer added a commit that referenced this issue Nov 1, 2014
Reset modifier only hotkey activation between key presses
@skurfer skurfer merged commit 998089f into master Nov 1, 2014
0 of 2 checks passed
@skurfer skurfer deleted the doubleKeyActivation branch Nov 1, 2014
skurfer added a commit that referenced this issue Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants