Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Extractor updates #2005

Merged
merged 3 commits into from Aug 1, 2015
Merged

URL Extractor updates #2005

merged 3 commits into from Aug 1, 2015

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Dec 17, 2014

Nothing huge. I was writing a blog post for work on Beautiful Soup and was looking over this script, finding things I now don鈥檛 like. 馃槂

The only behavioral difference is that it now includes links to places on the same page (like #this). I can鈥檛 remember why they were ever skipped. Anyone?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 18, 2014

The only reason I can think to ignore anchors is because of noise?

@skurfer
Copy link
Member Author

@skurfer skurfer commented Dec 19, 2014

Maybe. I鈥檒l try some real-world examples, but digging through noise quickly is sort of our specialty around here. 馃槂

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 29, 2015

This is just python and it's all pretty simple. I think this can be rebased and merged no problem.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Aug 1, 2015

Shouldn鈥檛 need a rebase, should it?

skurfer added a commit that referenced this issue Aug 1, 2015
@skurfer skurfer merged commit e866220 into master Aug 1, 2015
0 of 2 checks passed
@skurfer skurfer deleted the urlextract branch Aug 1, 2015
skurfer added a commit that referenced this issue Aug 1, 2015
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 2, 2015

Nope, cool

On Saturday, 1 August 2015, Rob McBroom notifications@github.com wrote:

Merged #2005 #2005.


Reply to this email directly or view it on GitHub
#2005 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants