Switch to new grabicon.com domain/API #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skurfer
added a commit
that referenced
this issue
Feb 11, 2015
Switch to new grabicon.com domain/API
skurfer
added a commit
that referenced
this issue
Feb 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If you've been using the web search plugin, you'll have noticed that the icons are all like this:
http://grabicon.com/icon?domain=https://example.com&size=32
That's because the API has changed slightly and we now need to provide an 'origin' parameter. Apparently if we go over our 'api limit' we won't be able to load more icons, so I've got in touch with the guys