restore the logic of catalogSetIndexPath #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiennou
added a commit
that referenced
this issue
May 28, 2015
restore the logic of catalogSetIndexPath
skurfer
added a commit
that referenced
this issue
May 28, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I ran across this the other day and
git bisectled me to acf0939I had to look closely to find the problem, but those methods weren’t actually duplicates. One of the
forloops starts at 0 and the other starts at 1. Maybe they could be consolidated into one that takes an argument, but for now, it works.