Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard OS X term for keyboard shortcuts #2070

Merged
merged 2 commits into from Jul 8, 2015
Merged

use standard OS X term for keyboard shortcuts #2070

merged 2 commits into from Jul 8, 2015

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jul 3, 2015

I tried to get all the user-visible strings and left the rest alone. Let me know if I missed anything.

@pjrobertson
Copy link
Member

pjrobertson commented Jul 3, 2015

A pretty big change for QS veterans! Was there something that prompted you to do this?
I agree that this is probably best, but I'm worried a backlash from existing users might make it more of a headache than we'd hope...!

@skurfer
Copy link
Member Author

skurfer commented Jul 4, 2015

Was there something that prompted you to do this?

It was always wrong. Don't you think? I just accepted it, but @hmelman called us out in it.

I agree that this is probably best, but I'm worried a backlash from existing users might make it more of a headache than we'd hope...!

I hope they have bigger priorities than this. 😀 And they're as able to submit pull requests as we are.

@pjrobertson
Copy link
Member

pjrobertson commented Jul 4, 2015

It was always wrong. Don't you think?

Yeah you're definitely right, but I just kinda think 'hotkey' has become a Quicksilver standard. Let's see how this goes

Do any of the locale files need changing? Do we need to update anything on Transifex?
If not, go ahead and merge :)

@skurfer
Copy link
Member Author

skurfer commented Jul 6, 2015

Do any of the locale files need changing?

I left the left-hand side the same, so a lot of those still say HotKey, but the user visible right-hand side is changed in the English translation. There are a few localizations that are just using the English version. Should we change the user-visible strings there, too? Should I change the left-hand side? Nothing will break if we do it everywhere, right?

Do we need to update anything on Transifex?

I don’t think so, since the “keys” used to look up translations haven’t changed. Though if it shows the English version as a guide, we should probably push the latest up there. Or if we change the keys like I asked about above.

@skurfer
Copy link
Member Author

skurfer commented Jul 8, 2015

Going ahead with this, since the changes in QSSearchPrefPane.xib are holding up something else. We can always tweak it later.

skurfer added a commit that referenced this issue Jul 8, 2015
use standard OS X term for keyboard shortcuts
@skurfer skurfer merged commit 7a78e1c into master Jul 8, 2015
@skurfer skurfer deleted the shortcut branch Jul 8, 2015
skurfer added a commit that referenced this issue Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants