Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a nicer fallback behavior for stringValue #2080

Merged
merged 3 commits into from Aug 3, 2015
Merged

provide a nicer fallback behavior for stringValue #2080

merged 3 commits into from Aug 3, 2015

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Aug 3, 2015

No more NSAssert().

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented on 1765a51 Aug 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization? ;-)

@tiennou
Copy link
Member

@tiennou tiennou commented Aug 3, 2015

Also, some explanation of why you're removing it would be nice ;-). I'm not fond of seeing some catalog tree search involved...

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 3, 2015

@tiennou - get on to IRC. Both Rob and I are sitting next to each other - quite a novelty! :D

I prefer to use encrypted email. You can find my public key here http://patjack.uk/pk.asc.
Learn how to encrypt your email with the Email Self Defense Guide https://emailselfdefense.fsf.org/en/

On 3 Awst 2015, at 10:32, Etienne Samson notifications@github.com wrote:

Also, some explanation of why you're removing it would be nice ;-). I'm not fond of seeing some catalog tree search involved...


Reply to this email directly or view it on GitHub #2080 (comment).

@skurfer
Copy link
Member Author

@skurfer skurfer commented Aug 3, 2015

Also, some explanation of why you're removing it would be nice

It hangs the interface. Good reason? 😃

If we’re trying to warn developers that they omitted something important, maybe we can just NSLog()?

pjrobertson added a commit that referenced this issue Aug 3, 2015
provide a nicer fallback behavior for stringValue
@pjrobertson pjrobertson merged commit a1b1556 into master Aug 3, 2015
1 check passed
@pjrobertson pjrobertson deleted the stringval branch Aug 3, 2015
skurfer added a commit that referenced this issue Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants