Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when trying to run the app on 10.8 #2096

Merged
merged 1 commit into from Nov 15, 2015
Merged

Warn users when trying to run the app on 10.8 #2096

merged 1 commit into from Nov 15, 2015

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 8, 2015

Turns out we made 1.3.0 10.9+ only, but forgot to change the warning in QSController

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 8, 2015

Yeah, I fixed that on another branch. Just haven’t gotten the pull request out. (It includes something more interesting.) Should have it out today or tomorrow, so going to hold off on this for now.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 8, 2015

OK no worries. Is your branch still fairly small? Not sure if I'm gonna have the time to look at anything big... interesting sounds... interesting though!

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 15, 2015

My guess is #2104 may take a while, now that Etienne's thrown his ideas into the mix. Can we merge and close this?

#2104 will need rebasing anyway if it is merged (there are conflicts) so @skurfer's commit changing this could just be removed

skurfer added a commit that referenced this issue Nov 15, 2015
Warn users when trying to run the app on 10.8
@skurfer skurfer merged commit 0ed1324 into master Nov 15, 2015
2 checks passed
@skurfer skurfer deleted the 10-8 branch Nov 15, 2015
skurfer added a commit that referenced this issue Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants