Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent documents for El Capitan #2100

Merged
merged 6 commits into from
Oct 1, 2015
Merged

recent documents for El Capitan #2100

merged 6 commits into from
Oct 1, 2015

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Sep 14, 2015

I sense we don鈥檛 have a lot of time, so hopefully one of you can look at this soon. 馃槃

fixes #2079

@pjrobertson
Copy link
Member

Sure thing I can look at it soon. Sorry for the flurry of comments 馃槩

@tiennou
Copy link
Member

tiennou commented Sep 14, 2015

FYI $objects key => NSCoder archive.

@skurfer
Copy link
Member Author

skurfer commented Sep 14, 2015

FYI $objects key => NSCoder archive.

Ah, OK. So how would I correctly read the values? Load the file as NSData instead and call initWithCoder:? How do you know which coder was used? Could it be private?

@tiennou
Copy link
Member

tiennou commented Sep 14, 2015

I'd say +[NSKeyedUnarchiver unarchiveObjectWithFile:]. Documentation

But I have no idea what you'll get back from it ;-). It might just be a little more future-proof (future-private-API-proof-lolno 馃槅). At least it might be easier to work with...

@skurfer
Copy link
Member Author

skurfer commented Sep 14, 2015

OK, have a look.

We get back SFLListItem objects, which I think is private, but I still trust this code more than what was there. Thanks!

@skurfer
Copy link
Member Author

skurfer commented Sep 30, 2015

It鈥檚 checking for nil URLs now. Let me know if there鈥檚 anything else.

@pjrobertson
Copy link
Member

No, that was all
I'm away from a computer... please merge :)
If need be we can get a release out for El Ca's release date

On Wednesday, 30 September 2015, Rob McBroom notifications@github.com
wrote:

It鈥檚 checking for nil URLs now. Let me know if there鈥檚 anything else.


Reply to this email directly or view it on GitHub
#2100 (comment)
.

skurfer added a commit that referenced this pull request Oct 1, 2015
recent documents for El Capitan
@skurfer skurfer merged commit d78a23a into master Oct 1, 2015
@skurfer skurfer deleted the recents1011 branch October 1, 2015 12:52
skurfer added a commit that referenced this pull request Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

El Capitan Public Beta: Drill from app to recent documents broken
3 participants