Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2111 #2152

Merged
merged 1 commit into from Nov 10, 2015
Merged

Fix for #2111 #2152

merged 1 commit into from Nov 10, 2015

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Nov 9, 2015

After much twiddling with debuggers and Flashlights, I think I got it.

The problem is that sometimes, the calculation of the containing scrollview doesn't end on an integral rect. This, returns this rect (origin = (x = 1.25, y = 1.25), size = (width = 57.5, height = 17.5)) which is then set as the scroll view frame, and this triggers a bug within the layout code where the text fields tries to adapt to that weird size but just ends up blowing up the stack because it's not pixel-aligned.

We might want check the various affected interfaces so this does not look too jarring visually.

@tiennou
Copy link
Member Author

tiennou commented Nov 9, 2015

#2111 (because cannot click)

@tiennou
Copy link
Member Author

tiennou commented Nov 9, 2015

I'm also wondering about Retina, because it uses by definition non-integral rects. Thus I'm not sold on it being a bug in framework code or a bug on our end...

Also, why is there a scroll view here ;-).

@skurfer
Copy link
Member

skurfer commented Nov 9, 2015

The long international nightmare could be over!

I tried a few interfaces on Retina and non-Retina and don’t see any visual weirdness. More importantly, I don’t see any crashes. 🎆

Thus I'm not sold on it being a bug in framework code or a bug on our end…

A recursive loop that ends in death is surely a bug, but if we can avoid triggering it…

Also, why is there a scroll view here ;-).

I sort of wondered the same thing.

skurfer added a commit that referenced this pull request Nov 10, 2015
@skurfer skurfer merged commit 66effe8 into master Nov 10, 2015
@skurfer skurfer deleted the t/fix-test-mode-crash branch November 10, 2015 19:49
skurfer added a commit that referenced this pull request Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants