Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explode Combined Objects #2188

Merged
merged 1 commit into from Mar 31, 2016
Merged

Explode Combined Objects #2188

merged 1 commit into from Mar 31, 2016

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Mar 12, 2016

A new action that does the same thing as ⌃⌘], as suggested in comments on #2092.

Maybe “explode” is the wrong word for the user-facing name. I’m open to suggestions.

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented on ed6a283 Mar 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this is messy, but we do this a load in hundreds of places. Need to restructure QS first... :P

skurfer
Copy link
Member Author

@skurfer skurfer commented on ed6a283 Mar 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it in an action doesn’t bother me as much as doing it in validation code. At least this way, it only runs in response to a user requesting it. But as often as that statement appears, there should probably be an easier way.

@pjrobertson pjrobertson merged commit a65675f into master Mar 31, 2016
2 checks passed
@pjrobertson pjrobertson deleted the explode branch Mar 31, 2016
skurfer added a commit that referenced this issue Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants