Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call the local setObjectValue when clearing #2190

Merged
merged 1 commit into from Mar 15, 2016
Merged

call the local setObjectValue when clearing #2190

merged 1 commit into from Mar 15, 2016

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Mar 15, 2016

I’m not sure of all the consequences, since the two implementations of setObjectValue: are pretty different. But since all we’re doing is wiping things out, the version in self seems to make more sense.

@pjrobertson
Copy link
Member

Cool. I think the key here is calling [self clearSearch]; which in turn invalidates the timer.
This'll need some hands on testing though to check for any side effects.

pjrobertson added a commit that referenced this pull request Mar 15, 2016
call the local setObjectValue when clearing
@pjrobertson pjrobertson merged commit fc487ca into master Mar 15, 2016
@pjrobertson pjrobertson deleted the i2189 branch March 15, 2016 15:04
@skurfer
Copy link
Member Author

skurfer commented Mar 15, 2016

I think the key here is calling [self clearSearch]; which in turn invalidates the timer.

Exactly. I was going to just call that, but noticed that [self setObjectValue:] already did.

This'll need some hands on testing though to check for any side effects.

Yeah, I’m running with it already.

skurfer added a commit that referenced this pull request Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants