Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific about when the 3rd pane should open/close #2235

Merged
merged 2 commits into from Jul 18, 2016
Merged

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 18, 2016

Fixes #2234 - see that for a full discussion.

The 2nd commit also fixes a usability bug I came across testing this:

  • 1st pane: type text
  • 2nd pane: choose 'Create File [...]'
  • Tab to 3rd pane to open it up
  • Select an object in the 3rd pane
  • Tab back to the 1st pane

Notice how the 3rd pane closes, hiding your selected object. The truth is, even though the 3rd pane is hidden its value will still be used when executing the action, so it should really stay open to make it more explicit to the user "this object will be used". If they don't want a 3rd pane action anymore they can just wipe it out with ⌃U as per usual

pjrobertson added 2 commits Jul 18, 2016
If the 3rd pane is optional, but you've already selected an object, don't close it when you tab away from it
@skurfer skurfer merged commit 14a6feb into master Jul 18, 2016
1 of 3 checks passed
@skurfer skurfer deleted the iSelectorDance branch Jul 18, 2016
skurfer added a commit that referenced this issue Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants