Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly reset the third pane #2239

Merged
merged 2 commits into from Jul 30, 2016
Merged

correctly reset the third pane #2239

merged 2 commits into from Jul 30, 2016

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jul 25, 2016

The method I changed is used for actions too, but it was already calling clearObjectValue, so the behavior there should be unchanged.

Everything in there is about to get new values on the following lines anyway. Different classes have different implementations of clearObjectValue. Calling it here makes sure the right clean-up steps are done.

fixes #2201
@pjrobertson
Copy link
Member

pjrobertson commented Jul 26, 2016

Excuse my forgetfulness, but which method did you change? I just did a quick git blame of the line you changed and it hasn't been changed for... 9 years :P

@skurfer
Copy link
Member Author

skurfer commented Jul 26, 2016

I was referring to the method I changed on this branch (updateControl:withArray:) and the changes made today.

@pjrobertson
Copy link
Member

pjrobertson commented Jul 30, 2016

merged in master and tests pass. Looks good

@pjrobertson pjrobertson merged commit e6e087f into master Jul 30, 2016
2 checks passed
@pjrobertson pjrobertson deleted the reset-indirects branch Jul 30, 2016
skurfer added a commit that referenced this issue Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants