Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check index validity during a scan #2241

Merged
merged 1 commit into from Jul 30, 2016
Merged

don't check index validity during a scan #2241

merged 1 commit into from Jul 30, 2016

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jul 26, 2016

It turns out the validity check was already happening on the correct queue, but it could get stuck waiting for that queue, as shown in #2016.

Checking validity often ties up the same resources as the scan itself (and definitely requires the same queue).

fixes #2016
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 30, 2016

seems to make sense to me

@pjrobertson pjrobertson merged commit b859738 into master Jul 30, 2016
2 checks passed
@pjrobertson pjrobertson deleted the indexing branch Jul 30, 2016
skurfer added a commit that referenced this issue Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants