Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid hang in stringValue #2243

Merged
merged 7 commits into from Aug 4, 2016
Merged

avoid hang in stringValue #2243

merged 7 commits into from Aug 4, 2016

Commits on Jul 27, 2016

  1. avoid an infinite stringValue loop

    splitObjects tries three things: check if count is 1, check for object components, get children. We already know the count is not one, and getting children (if it doesn't cause a loop) just splits the string on \n, which we would only reverse here. So go straight for the object components.
    
    fixes #2242
    skurfer committed Jul 27, 2016
    Copy the full SHA
    c43577d View commit details
    Browse the repository at this point in the history
  2. get the text type directly in triggers

    stringValue is a bit heavy handed. We know the text is present since we test for it, and we know that's what stringValue will end up returning (after doing many tests).
    skurfer committed Jul 27, 2016
    Copy the full SHA
    6493ac0 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2016

  1. Copy the full SHA
    2fbbf5d View commit details
    Browse the repository at this point in the history
  2. Comment on direct access of object components

    (and why we didn't use `[obj splitObjects]`. More info in the commit message of c43577d
    pjrobertson committed Aug 3, 2016
    Copy the full SHA
    cb9a74b View commit details
    Browse the repository at this point in the history
  3. Make getting app support path more reliable

    In unit tests, calling QSGetApplicationSupportFolder() might return nil and cause a crash - because QSApplicationSupportPath was never set.
    These changes make sure it's always set (and in fact stop QSApplicationSupportPath from being extern
    pjrobertson committed Aug 3, 2016
    8
    Copy the full SHA
    d804258 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2016

  1. Copy the full SHA
    20e1372 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    411f73a View commit details
    Browse the repository at this point in the history