Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only hide the interface after everything has been set up for execution #2269

Merged
merged 1 commit into from Sep 8, 2016

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Sep 2, 2016

Fixes #2268 while keeping the "clear on close" behavior of aeaa261

Fixes #2268 while keeping the "clear on close" behavior of aeaa261
@skurfer
Copy link
Member

@skurfer skurfer commented Sep 8, 2016

Seems to work. Wish I could figure out why saveMnemonic gets hit twice when you type . It claims to be coming from insertNewline: both times, but if I move the breakpoint there, it only gets hit once.

Another issue for another day.

@skurfer skurfer merged commit fa14b95 into master Sep 8, 2016
2 checks passed
@skurfer skurfer deleted the fix-mnemonics branch Sep 8, 2016
skurfer added a commit that referenced this issue Sep 8, 2016
pjrobertson added a commit that referenced this issue Jan 3, 2017
The problem is that clearing the search string too early means mnemonics are not saved, so if we move the mnemonic saving code earlier this fixes it.
The reason we want to clear the search string on interface close is a UI thing. See this comment: #2249
Fixes #2302
Fixes #2300
Related to #2268 #2269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants