Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change deployment to 10.10 #2295

Merged
merged 4 commits into from Dec 13, 2016
Merged

change deployment to 10.10 #2295

merged 4 commits into from Dec 13, 2016

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Dec 8, 2016

Another attempt…

Same as last time, but I was able to squash the comment updates into the other commit.

NIBs were updated and saved using Xcoe 7.2.1 this time.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 9, 2016

all looks good, builds fine. I wrote one small comment, once that's fixed I say go ahead. (I haven't tested/built this, but I trust Travis)

@skurfer
Copy link
Member Author

@skurfer skurfer commented Dec 9, 2016

I don’t see a comment anywhere @pjrobertson.

One thing I forgot to mention… I didn’t update QSHelpersPrefPane.xib because I couldn’t. Opening it and saving it (without changes) crashes Xcode (7 and 8). In Xcode 8, just selecting it will eventually lead to a crash. Any ideas?

}
#pragma clang diagnostic pop
#endif

+ (NSString *)macOSXReleaseVersion {
return [NSString stringWithFormat:@"%i.%i", (int)[self macOSXMajorVersion], (int)[self macOSXMinorVersion]];
Copy link
Member

@pjrobertson pjrobertson Dec 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... my comment disappeared. Although I clicked 'start a review' instead of 'add single comment' (some new GH feature?)

I was just saying that it's probably better to not cast to int, although it probably won't make much of a difference. I'd use %ld then cast to a long. Although this has other suggestions: http://stackoverflow.com/questions/4405006/nslog-printf-specifier-for-nsinteger

Tiny/nit-picking comment, sorry! :P

}
#pragma clang diagnostic pop
#endif

+ (NSString *)macOSXReleaseVersion {
return [NSString stringWithFormat:@"%i.%i", (int)[self macOSXMajorVersion], (int)[self macOSXMinorVersion]];
Copy link
Member

@pjrobertson pjrobertson Dec 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... my comment disappeared. Although I clicked 'start a review' instead of 'add single comment' (some new GH feature?)

I was just saying that it's probably better to not cast to int, although it probably won't make much of a difference. I'd use %ld then cast to a long. Although this has other suggestions: http://stackoverflow.com/questions/4405006/nslog-printf-specifier-for-nsinteger

Tiny/nit-picking comment, sorry! :P

}
#pragma clang diagnostic pop
#endif

+ (NSString *)macOSXReleaseVersion {
Copy link
Member

@pjrobertson pjrobertson Dec 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... my comment disappeared. Although I clicked 'start a review' instead of 'add single comment' (some new GH feature?)

I was just saying that it's probably better to not cast to int, although it probably won't make much of a difference. I'd use %ld then cast to a long. Although this has other suggestions: http://stackoverflow.com/questions/4405006/nslog-printf-specifier-for-nsinteger

Tiny/nit-picking comment, sorry! :P

@skurfer
Copy link
Member Author

@skurfer skurfer commented Dec 10, 2016

The suggestions from SO are interesting, but since we’re 64-bit only, I’ve gone with long as you suggested.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 12, 2016

Once it's been compiled and built can you actually open the QSHelpersPrefPane panel? So it's just Xcode's problem or what?
So I just managed to open it by navigating to the file in Finder then double clicking. Do you want to merge this then I'll take a stab at updating that Nib?

I'm on 10.11 / Xcode 8.1

@skurfer
Copy link
Member Author

@skurfer skurfer commented Dec 13, 2016

That’s “Handlers”, right? I can open it in the prefs. I can also open it in Xcode most of the time, but saving it is a disaster. It crashes Xcode 8, which tries to open it every time you relaunch and immediately crashes again. You have to delete your workspace files to make it forget you had that file selected.

Maybe we need to install a much older Xcode and try to update it incrementally?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 13, 2016

@skurfer skurfer merged commit cdf7caa into master Dec 13, 2016
1 of 2 checks passed
@skurfer skurfer deleted the tenten branch Dec 13, 2016
skurfer added a commit that referenced this issue Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants