change deployment to 10.10 #2295
Conversation
|
all looks good, builds fine. I wrote one small comment, once that's fixed I say go ahead. (I haven't tested/built this, but I trust Travis) |
|
I don’t see a comment anywhere @pjrobertson. One thing I forgot to mention… I didn’t update |
| } | ||
| #pragma clang diagnostic pop | ||
| #endif | ||
|
|
||
| + (NSString *)macOSXReleaseVersion { | ||
| return [NSString stringWithFormat:@"%i.%i", (int)[self macOSXMajorVersion], (int)[self macOSXMinorVersion]]; |
There was a problem hiding this comment.
hmm... my comment disappeared. Although I clicked 'start a review' instead of 'add single comment' (some new GH feature?)
I was just saying that it's probably better to not cast to int, although it probably won't make much of a difference. I'd use %ld then cast to a long. Although this has other suggestions: http://stackoverflow.com/questions/4405006/nslog-printf-specifier-for-nsinteger
Tiny/nit-picking comment, sorry! :P
| } | ||
| #pragma clang diagnostic pop | ||
| #endif | ||
|
|
||
| + (NSString *)macOSXReleaseVersion { | ||
| return [NSString stringWithFormat:@"%i.%i", (int)[self macOSXMajorVersion], (int)[self macOSXMinorVersion]]; |
There was a problem hiding this comment.
hmm... my comment disappeared. Although I clicked 'start a review' instead of 'add single comment' (some new GH feature?)
I was just saying that it's probably better to not cast to int, although it probably won't make much of a difference. I'd use %ld then cast to a long. Although this has other suggestions: http://stackoverflow.com/questions/4405006/nslog-printf-specifier-for-nsinteger
Tiny/nit-picking comment, sorry! :P
| } | ||
| #pragma clang diagnostic pop | ||
| #endif | ||
|
|
||
| + (NSString *)macOSXReleaseVersion { |
There was a problem hiding this comment.
hmm... my comment disappeared. Although I clicked 'start a review' instead of 'add single comment' (some new GH feature?)
I was just saying that it's probably better to not cast to int, although it probably won't make much of a difference. I'd use %ld then cast to a long. Although this has other suggestions: http://stackoverflow.com/questions/4405006/nslog-printf-specifier-for-nsinteger
Tiny/nit-picking comment, sorry! :P
|
The suggestions from SO are interesting, but since we’re 64-bit only, I’ve gone with |
|
Once it's been compiled and built can you actually open the QSHelpersPrefPane panel? So it's just Xcode's problem or what? I'm on 10.11 / Xcode 8.1 |
|
That’s “Handlers”, right? I can open it in the prefs. I can also open it in Xcode most of the time, but saving it is a disaster. It crashes Xcode 8, which tries to open it every time you relaunch and immediately crashes again. You have to delete your workspace files to make it forget you had that file selected. Maybe we need to install a much older Xcode and try to update it incrementally? |
|
OK, go ahead and merge. I have Xcode 6 on a Snow Leopard VM I think, I can try and go through the motions there.
… On 13 Dec 2016, at 10:39, Rob McBroom ***@***.***> wrote:
That’s “Handlers”, right? I can open it in the prefs. I can also open it in Xcode most of the time, but saving it is a disaster. It crashes Xcode 8, which tries to open it every time you relaunch and immediately crashes again. You have to delete your workspace files to make it forget you had that file selected.
Maybe we need to install a much older Xcode and try to update it incrementally?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2295 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJLnyhFqh_lOb6DlHCqzXrTQIuhbE6iks5rHgVggaJpZM4LH4_P>.
|
Another attempt…
Same as last time, but I was able to squash the comment updates into the other commit.
NIBs were updated and saved using Xcoe 7.2.1 this time.