Another go at ensuring search string is cleared when closing interface #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that clearing the search string too early means mnemonics are not saved, so if we move the mnemonic saving code earlier this fixes it. The reason we want to clear the search string on interface close is a UI thing. See this comment: #2249 Fixes #2302 Fixes #2300 Related to #2268 #2269
|
P.S. do I win an award for the most long-winded commit message?! :D |
tiennou
reviewed
Jan 3, 2017
| if (!cont) { | ||
| // this ensures the interface is hidden before an action is run e.g. the 'capture screen region' and 'type text' actions needs this | ||
| [self hideMainWindowFromExecution:self]; // *** this should only hide if no result comes in like 2 seconds | ||
| } |
There was a problem hiding this comment.
If you restore that one, maybe the if (cont)-else branch below should go ?
There was a problem hiding this comment.
oh wait yeah, you mean line 660
|
I’ll go ahead and make the change to the if/else on this branch, and hopefully also add a fix for #2301. |
|
sorry, you probably heard the pollution levels in Beijing were through the roof this week (I'm running a startup educating people about air pollution here in Beijing) so I didn't have a second to breath this week. Will make the change now |
Left over from 2b2cc2d
|
Done |
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The problem is that clearing the search string too early means mnemonics are not saved, so if we move the mnemonic saving code earlier this fixes it.
The reason we want to clear the search string on interface close is a UI thing. See this comment: #2249 (comment)
Fixes #2302
Fixes #2300
Related to #2268 #2269
OK guys take a look at this. Basically, I took a look at what @tiennou had done in 2b2cc2d but realised that that
if (!cont) {}code is needed but understood why Etienne was doing this - because closing the interface meant the search string was cleared, which meant mnemonics could not be saved (since that was done later on).Instead, what I did was to make saving the mnemonics happen earlier. Now I'm not sure of the consequences of saving mnemonics before an action has been run. Does anybody know?
I've just done some testing, and in fact saving the mnemonics too late caused other bugs.
For example take the an action that accepts an iObject, e.g.
[some folder] ⇥ [make new...] ⇥ [my folder]This action returns an object (the newly created folder) and displays it in the interface. The new object is created and returned when the action is executed (see
-[QSInterfaceController executeCommandThreaded] -> -[QSCommand execute] ->which leads to here where the interface is cleared), which is before the mnemonics were originally saved. This way the mnemonic would never be saved for the original[some folder]object, since it's already been cleared for the newly created folder.Make sense?
In short - we need to be sure that saving the mnemonic before executing the command doesn't cause more harm than good