Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don’t add identifiers to string objects #2325

Merged
merged 1 commit into from
Mar 15, 2017
Merged

don’t add identifiers to string objects #2325

merged 1 commit into from
Mar 15, 2017

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Mar 3, 2017

Of course git blame said “look in the mirror” on this one.

@pjrobertson
Copy link
Member

haha, smart git blame! ;-)

Why does giving a string object replace its identifier? Because its identifier is the string value right? I remember in the past I tried to give string objects the identifier QSString:[the string value] but that still caused problems with triggers. I guess that's what was happening again?

Damn this thing is messy!

@skurfer
Copy link
Member Author

skurfer commented Mar 4, 2017

I found the old discussions.

#1505 (comment)
#1569

Sounds like we were going to try to fix it “for real” one day so everything could safely have an identifier. I guess that day hasn’t come yet. 😃

I re-introduced the problem (for reasons I can’t explain) when moving the object dictionary to QSLibrarian.

@skurfer skurfer merged commit eadcab4 into master Mar 15, 2017
@tiennou tiennou deleted the stringid branch November 28, 2017 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants