Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation cleanup #2346

Merged
merged 19 commits into from Apr 21, 2017
Merged

Deprecation cleanup #2346

merged 19 commits into from Apr 21, 2017

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Apr 19, 2017

I closed #2257 in error it seems. Here's a rejig of it. I still need to fix the comments made there, but I would really like it to go in.

@skurfer
Copy link
Member

@skurfer skurfer commented Apr 20, 2017

Code looks good. I’ve merged this into my local build so I can test.

tiennou added a commit to quicksilver/com.apple.Safari-qsplugin that referenced this issue Apr 20, 2017
@tiennou
Copy link
Member Author

@tiennou tiennou commented Apr 20, 2017

I've added a few more easy ones.

  • The catalog fixes are in catalog/clean-obj-source #2255.
  • I don't think the QSCatalogEntry changes allows us to get rid of the NSNib warnings yet (need to keep the topLevelObjects array around)
  • Most of the LS ones are "deprecated in 10.10, new in 10.10", so thanks Apple for the mess...
  • I think the NSWorkspace ones could go as soon as we get the process management (which is in deprecation/breaking).
  • Some of the alert ones are there too, but maybe we want to change some of those to notifications, so it's likely I'll post it separately.
  • I seem to remember there was "riots" when trying to fix the WebFrame*Delegate ones, but I can't remember. Was that 10.9+ ?

@skurfer skurfer merged commit a7d6fb2 into master Apr 21, 2017
0 of 2 checks passed
@skurfer skurfer deleted the deprecation/cleanup branch Apr 21, 2017
skurfer added a commit that referenced this issue Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants