Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove xctool #2353

Merged
merged 1 commit into from Jun 2, 2017
Merged

remove xctool #2353

merged 1 commit into from Jun 2, 2017

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Apr 29, 2017

I’ve had it commented out in the build script for months. Time to make it official.

it doesn’t support Xcode 8+
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 30, 2017

I can't remember why we used xctool... I this we chose to use it for Travis because it worked better for headless systems. Yeah I think that was it. See #2021. Is it OK that we're using two different testing tools for CI and for builds?

Why did you have it commented out?

@skurfer
Copy link
Member Author

@skurfer skurfer commented Apr 30, 2017

I can't remember why we used xctool...

I thought the reason was that the Quicksilver tests involving the GUI would never pass under xcodebuild (even locally).

Is it OK that we're using two different testing tools for CI and for builds?

Actually, I wasn’t thinking about Travis, just the local release builds. I should probably update that file to use a newer Xcode and a different test command. Agree?

Why did you have it commented out?

Because the default on my system is Xcode 8, so xctool would always die. I’d switch to Xcode 7 and re-enable it for actual releases.

@skurfer skurfer merged commit d29162c into master Jun 2, 2017
0 of 2 checks passed
@skurfer skurfer deleted the rmxctool branch Jun 2, 2017
skurfer added a commit that referenced this issue Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants