Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use string value as identifier for string objects #2369

Merged
merged 1 commit into from Mar 2, 2018
Merged

use string value as identifier for string objects #2369

merged 1 commit into from Mar 2, 2018

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jun 14, 2017

I nearly did this before, but decided not to based on the fear that if you were to type (or paste) an existing object’s identifier in text mode, the string object representing the identifier would replace the real object in the catalog. That doesn’t seem to be the case.

You do get some weirdness with history (you can’t store both an object and a string with its identifier), but that’s an edge case I don’t think we need to worry about.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Jun 14, 2017

Already found one huge problem with this: It completely breaks ⌘A and ⌘⎋ for multiple files.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Jan 18, 2018

This no longer causes the previously mentioned problems. I suspect it has to do with recent changes to the way collections are displayed. No hurry to merge. I’d like to run it for a while to be sure.

@skurfer skurfer reopened this Jan 18, 2018
@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 13, 2018

I haven’t seen any problems running this.

@skurfer skurfer merged commit 74dc2b3 into master Mar 2, 2018
2 checks passed
@skurfer skurfer deleted the i2364 branch Mar 2, 2018
skurfer added a commit that referenced this issue Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant