Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for Constellation Menus plugin #239

Closed

Conversation

ddlsmurf
Copy link
Contributor

@ddlsmurf ddlsmurf commented Apr 23, 2011

I know this is the wrong place for that method, but it makes the default action work for constellation menus, a plugin for which I couldn't find the source code

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Apr 23, 2011

Hmm...I just tested it. With this fix the constellation menus show up. But there are also other problems in there.
For example once the menu is up, when you press an arrow button, it crashes again. Error message:

-[QSRadialMenu moveRight:]: unrecognized selector sent to instance 0x13b86530 

@ddlsmurf
Copy link
Contributor Author

@ddlsmurf ddlsmurf commented Apr 23, 2011

Yes, it's very incomplete, but using these settings http://s-softs.com/skitch/Preferences-20110424-013047.png the menus run the default action when show using the "Show Radial Menu" action, can't vouch for any other configurations/uses

@ghost
Copy link

@ghost ghost commented Apr 24, 2011

double-clicking a folder to view it's contents and right-clicking/clicking and holding an object's icon to view the actions menu for it all work as well.

maybe the source code to this plugin was among the stuff Alcor sent @pjrobertson?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 24, 2011

Unfortunately not.
If we could get a list of missing source together, I will try and get in touch with Alcor for the rest of the source (no promises, as I'm sure you know what he's like)

@ghost
Copy link

@ghost ghost commented Jun 8, 2011

is there any reason this change shouldn't be merged? even though the plugin has other bugs, this is as fixed as it's going to get unless someone rewrites it.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 8, 2011

you're right. go ahead and merge it

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 14, 2011

I'm pretty sure I just merged this. For some reason it created a different commit SHA, so github doesn't recognize it. Well, it is merged, so I'll close it.

@HenningJ HenningJ closed this Jun 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants