Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redefine Relaunch as a trigger #2404

Merged
merged 2 commits into from Oct 23, 2017
Merged

redefine Relaunch as a trigger #2404

merged 2 commits into from Oct 23, 2017

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Oct 16, 2017

As promised.

  • enabled by default
  • scoped to be active only in Quicksilver
  • uses ⌃⌥⌘Q by default

Since it’s a trigger, users on 10.12 or older can change it back or change it to something else if they want.

@pjrobertson
Copy link
Member

Nice, looks good. We need to make it pretty clear for existing users since this will be a break in workflow. How bad would it be to make the trigger default ⌘⌃Q?

@skurfer
Copy link
Member Author

skurfer commented Oct 22, 2017

How bad would it be to make the trigger default ⌘⌃Q?

Well, the new one has the advantage of working on all OS versions. It also makes it obvious that something has changed. People might assume it’s “broken” forever otherwise.

@pjrobertson pjrobertson merged commit 1329bac into master Oct 23, 2017
@pjrobertson
Copy link
Member

Sounds reasonable. I'm sure you'll make it clear in the changelog anyway ;-)

@pjrobertson pjrobertson deleted the relaunch branch October 23, 2017 23:59
skurfer added a commit that referenced this pull request Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants