Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point 'more info' button to Changelog page, not just website homepage #2486

Merged
merged 8 commits into from Mar 12, 2019

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 1, 2019

I went to actually update QS today (yes, I haven't updated for over 1 year. Shame on me!) only to find out that there is a new version (thanks @skurfer ).

I figured this 'More info' button could actually point to the changelog though :/

screenshot 2019-02-01 at 13 09 11

@skurfer
Copy link
Member

skurfer commented Feb 1, 2019

Agreed. Maybe we should also change kHelpURL to the manual, now that it’s online?

@pjrobertson
Copy link
Member Author

pjrobertson commented Feb 3, 2019

Yep, makes sense. Does that mean we want to deprecate the wiki? If not, we should at least have a link to the wiki from the manual (explained as a 'repository of user tips and scripts')

@pjrobertson
Copy link
Member Author

pjrobertson commented Feb 3, 2019

Oh how I've missed QS coding...! What you'd have thought was a simple one liner change turned into a can of worms! Turns out some of the help code was never used, so I've removed it.

Secondly, I couldn't get this to build because Xcode was complaining about certain string files (Thai, Portuguese) not being in the right encoding. I played around with changing the encoding to UTF-8 but didn't want to break anything anywhere else so left things as is.

screenshot 2019-02-03 at 09 44 06

@skurfer what are the file encodings of the Thai string files on your computer (go to the Quicksilver/Localised/th.lproj folder and run file -I ./*
@tiennou would also be interested on your input on the strings thing. I'd argue to convert everything to UTF-8 then tell Xcode they're all UTF-8, but I'm wondering if things have got messy because the encoding changes locally on my computer?

@skurfer
Copy link
Member

skurfer commented Feb 4, 2019

Wow. I haven’t been paying attention either. I just saw #2476. 🤦‍♂️ I can probably close that guy at this point.

As for the encodings, it’s not your computer. I had the same problem in Xcode 10. Still using 9 for releases, but I thought I had pushed a fix for that to master at some point. Maybe not. I will.

This looks OK so far. I’ll look closer later on.

@skurfer
Copy link
Member

skurfer commented Feb 7, 2019

I’ve merged my changes, since there were some more files touched, and made some small fixes here. I’m good to merge this if you are.

@skurfer skurfer merged commit 1257b79 into master Mar 12, 2019
2 checks passed
@skurfer skurfer deleted the more-info branch Mar 12, 2019
skurfer added a commit that referenced this issue Mar 12, 2019
@pjrobertson
Copy link
Member Author

pjrobertson commented Apr 24, 2019

I never replied, but all looks good. Thanks for doing the tidying up and typo fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants