Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make length of QSHistory editable #2490

Merged
merged 3 commits into from Apr 23, 2019
Merged

Make length of QSHistory editable #2490

merged 3 commits into from Apr 23, 2019

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 16, 2019

Nothing much here. I realised the QSHistory preset in the catalog (Catalog > Quicksilver > Recent Objects) is limited to 50. That's not enough for me.

I made it a hidden preferences to allow you to edit this value (ideally it'd be a setting in the Catalog UI but I don't have the time for this :(

(By setting an NSUSerDefaults value)
@skurfer
Copy link
Member

skurfer commented Apr 16, 2019

OK, but I say we get rid of MAXHIST entirely and set the default in QSDefaults.plist, since that’s the standard way we handle such things.

@tiennou
Copy link
Member

tiennou commented Apr 16, 2019

And I say "add it to the Advanced prefs" 😉. IIRC it's just about a few lines in a plist (if it supports integer values).

@skurfer
Copy link
Member

skurfer commented Apr 18, 2019

I did the things. 🆒

@pjrobertson
Copy link
Member Author

pjrobertson commented Apr 23, 2019

Looks good. Can I merge a PR that I started? I say yes! :D

@pjrobertson pjrobertson merged commit bb6b883 into master Apr 23, 2019
2 checks passed
@pjrobertson pjrobertson deleted the history-size branch Apr 23, 2019
@skurfer
Copy link
Member

skurfer commented Apr 23, 2019

Yup.

@skurfer
Copy link
Member

skurfer commented Apr 23, 2019

Of course I just noticed this, but you can’t actually change the number in Extras. You can see what it is, though! 😁

skurfer added a commit that referenced this issue Apr 23, 2019
@tiennou
Copy link
Member

tiennou commented Apr 23, 2019

Gosh, I wonder whose fault it is 😁.

I was pretty sure it was working… Oh well, at least it's somewhat auto-documenting.

@pjrobertson
Copy link
Member Author

pjrobertson commented Apr 24, 2019

😨 Ooops!

I think we should try and do away with the 'Extras' tab in the future anyway. It's not very self-explanatory, and some of the prefs should maybe even be deleted. Another job for another day :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants