Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of TLDs #2493

Merged
merged 2 commits into from Jul 29, 2019
Merged

Update list of TLDs #2493

merged 2 commits into from Jul 29, 2019

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 18, 2019

Turns out there are quite a few more TLDs these days! Just tried to type 'something.watch' into QS, which didn't work. Updated based on latest list I just pulled from IANA

@skurfer
Copy link
Member

skurfer commented May 21, 2019

Cool. does this kill string sniff performance?

@pjrobertson
Copy link
Member Author

pjrobertson commented Jul 27, 2019

Good question. I haven't profiled it, but my guess is since all we're doing is one lookup on an NSArray for the TLD, we're not really going to be hampering performance. And still, this check only gets run on strings that:
a) already have a dot (.) in them
b) don't have any whitespace
c) don't have a @ in them
d) don't have more than one : in them
...

the list goes on. I think the point here is that this is actually one of the last checks to get done, when it's quite likely the string is in fact a URL

@skurfer skurfer merged commit 7d04c7f into master Jul 29, 2019
2 checks passed
@skurfer skurfer deleted the tlds branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants