Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NSRunningApplication for app management #2500

Merged
merged 1 commit into from Sep 25, 2019
Merged

Use NSRunningApplication for app management #2500

merged 1 commit into from Sep 25, 2019

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 27, 2019

Deprecate and move away from the old NSWorkspace style app dicts.
This should fix #2482 as well as just generally clean up the code

We can't move away from the old style completely, because some plugins still use it. But it's nice to at least make a start... baby steps :P

Also: ideally we'd switch QSObjects that represent running processes (stored in the QSProcessType data key) to also use NSRunningApplication instead of these NSDicts, but again... baby steps. Assuming this code has no big problems, that would be the next step

Deprecate and move away from the old NSWorkspace style app dicts.
This should fix #2482 as well as just generally clean up the code
@skurfer skurfer merged commit eeade06 into master Sep 25, 2019
2 checks passed
@skurfer skurfer deleted the nsrunningapp branch Sep 25, 2019
skurfer added a commit that referenced this issue Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants